Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#61891 closed defect (fixed)

tix @8.4.3_3 +quartz: error: implicit declaration of function 'panic' is invalid in C99

Reported by: lmhaffner Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.6.4
Keywords: bigsur catalina Cc:
Port: tix

Description

tix fails to build on macOS 11.x and XCode 12.3 with the new "implicit declaration" warning being elevated to a compiler error.

Example line from the log (attached): 

:info:build ./generic/tixDiStyle.c:788:2: error: implicit declaration of function 'panic' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build         panic("DItem is already associated with style");

Attachments (1)

main.log​ (80.3 KB) - added by lmhaffner 3 years ago.
Build log

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by lmhaffner

Attachment: main.log​ added

Build log

comment:1 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: catalina added
Owner: set to ryandesign
Status: new → accepted
Summary: tix @8.4.3_3 +quartz - Build failure - panic implicit declaration causes error → tix @8.4.3_3 +quartz: error: implicit declaration of function 'panic' is invalid in C99

comment:2 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: accepted → closed

In 80d3dcac293a2a80c1a503c9a8f6e231ffd98001/macports-ports (master):

tix: Fix implicit declaration of functions

Closes: #61891

comment:3 Changed 3 years ago by chrstphrchvz (Christopher Chavez)

In 2982768a78e7a7cacadbe8f8db42561bedd4f531/macports-ports (master):

tix: specify X11 paths, patch cleanup

Revert implicit function declaration fix attempt from 80d3dcac29:
Tcl/Tk projects (as of 8.4) are to use Tcl_Panic() instead of panic(),
and typically prefer to not include standard library headers directly
from individual source files.
macportshttps://github.com/macports/macports-ports/pull/9400 was already open when the issue was reported via trac
See: #61891

+x11 variant: provide explicit paths to ensure MacPorts' libX11 is used

Note: See TracTickets for help on using tickets.