fig2dev @3.2.8 fix build failure for 10.6, less build and runtime requirements

[tloimer]

I noticed that fig2dev 3.2.8 does not build on 10.6. Could you try to add the line #include <sys/types.h> in the file fig2dev/lib/getline.h and see, whether the build passes?
Build requirements: xpm is not required.
Runtime requirements: not netpbm, but (netpbm or imagemagick or graphicsmagick) and ghostscript.
Both requirements are optional, but recommended.

[kencu (Ken)]

I'll take a look.

[kencu (Ken)]

first off, I do have it installed:

$ port -v installed fig2dev
The following ports are currently installed:
  fig2dev @3.2.7b_2 (active) platform='darwin 10' archs='x86_64' date='2020-07-05T20:43:28-0700'

and I just rebuilt it without any troubles, without touching the portfile.

Log will be attached.

SO -- not sure if there is a problem here to fix.

[kencu (Ken)]

successful build, 10.6.8 / libc++

[kencu (Ken)]

OH -- I see I built 3.2.7b. I will try the apparently updated version next.

[kencu (Ken)]

Yes, you are exactly right. Adding that header fixed it:

$ port -v installed fig2dev
The following ports are currently installed:
  fig2dev @3.2.7b_2 platform='darwin 10' archs='x86_64' date='2020-07-05T20:43:28-0700'
  fig2dev @3.2.8_0 (active) platform='darwin 10' archs='x86_64' date='2020-12-23T16:43:47-0800'

I will pop in a patch while you consider adding that header to all builds, I presume.

Thanks!

[kencu (Ken)]

beautiful job on the test suite on 10.6.8 as well, by the way!

/usr/bin/make  check-local
/bin/sh './testsuite' INSTALLCHECK=no 
## ------------------------- ##
## fig2dev 3.2.8 test suite. ##
## ------------------------- ##

Correctly process the command line.

  1: do not overwrite .fig file                      ok

Parse color specifications (test lookup_X_color() in colors.c)

  2: accept correct hexadecimal rgb-values           ok
  3: fail on malformed hexadecimal rgb-values        ok
  4: use built-in color database, blanks in names    ok

Read installed files.

  5: $i18ndir/cs_CZ.ps must exist                    skipped (input.at:68)

Find and decompress embedded image files.

  6: name in fig file img.gz, file img.gz, pipe ok   ok
  7: name in fig file img.Z, file img.Z, no pipe     ok
  8: name in fig file img, file img.gz, pipe ok      ok
  9: name in fig file img, file img.z, no pipe       ok
 10: name in fig file img, file img.Z, pipe ok       ok
 11: absolute path in fig file, pipe ok              ok

Sanitize and harden input.

 12: co-incident points                              ok
 13: open rectangle                                  ok
 14: open arc box                                    ok
 15: open polygon                                    ok
 16: convert box to polygon                          ok
 17: convert malformed, open box to a polygon        ok
 18: fail on a malformed arc-box                     ok
 19: fail on a distorted arc-box                     ok
 20: fail on a distorted arc-box                     ok
 21: remove arrows tips from single point            ok
 22: reject huge arrow-type, ticket #57              ok
 23: convert short polygon to polyline, ticket #56   ok
 24: reject negative font type                       ok
 25: allow negative circle or ellipse radii          ok
 26: survive debian bugs #881143, #881144            ok
 27: reject out-of-range pattern, debian bug #881396 ok
 28: survive debian bug #890016                      ok
 29: ignore too many comment lines, ticket #25       ok
 30: correctly free invalid line object, ticket #26  ok
 31: correctly free invalid spline, ticket #27       ok
 32: allow last line without newline, ticket #28     ok
 33: correctly free invalid line object              ok
 34: correctly free invalid line with picture        ok
 35: ignore splines with one point, ticket #29       ok
 36: ignore splines with one point in format 1.3     ok
 37: set invalid color number to default, ticket #30 ok
 38: set ppi when reading fig files format 1.3       ok
 39: process circle arrow at mag > 42, ticket #52    ok
 40: allow text ending with multiple ^A, ticket #55  ok
 41: reject too long papersize specification         ok
 42: allow tex font -1, tickets #71, #75, #81        ok
 43: reject ASCII NUL ('\0') in input, ticket #80    ok
 44: reject out of range text angle, ticket #76      ok
 45: reject out-of-range pattern fills, ticket #63   ok
 46: allow files end without eol, tickets #83, #84   ok
 47: do not reach beyond buffer, ticket #85          ok
 48: reject negative font size, ticket #86           ok

Dynamically allocate picture file name.

 49: prepend fig file path to picture file name      ok

Test PostScript output language.

 50: compare arrow tips with template                ok
 51: do not clip 0-width objects having arrows, #53  ok
 52: honor SOURCE_DATE_EPOCH environment variable    ok
 53: fail on text in SOURCE_DATE_EPOCH               ok

Test pict2e output language.

 54: ignore -G option                                ok
 55: accept large coordinates                        ok
 56: accept arc arrows with zero height, ticket #74  ok

Test svg output language.

 57: compare patterns with template                  ok
 58: compare fills with arrows to template           ok

Test tikz output language.

 59: conditionally allocate \XFigu                   ok
 60: pattern with stroke color equal to fill color   ok
 61: accept large coordinates                        ok

Test other output languages.

 62: allow default color in ge, cgm output, #72, #73 ok

Create and embed bitmaps in fig-file.

 63: gif                                             ok
 64: jpeg                                            ok
 65: pcx                                             ok
 66: png                                             ok
 67: png with smoothing                              ok
 68: ppm                                             ok
 69: tiff                                            ok
 70: xbm                                             ok
 71: xbm with smoothing                              ok
 72: xpm                                             ok

Creation of temporary files.

 73: eps with acscii preview                         ok
 74: eps with tiff preview                           ok

Embed postscript variants.

 75: epsi                                            ok
 76: postscript, created by fig2dev                  ok
 77: postscript, created by latex                    ok
 78: find /MediaBox in pdf file                      ok
 79: pdf                                             ok

## ------------- ##
## Test results. ##
## ------------- ##

78 tests were successful.
1 test was skipped.
make[2]: Nothing to be done for `check-am'.
Making check in man
make[1]: Nothing to be done for `check'.
make[1]: Nothing to be done for `check-am'.

[kencu (Ken)]

In 3e3668e590aa3bac061d4ebae48216411e2c6308/macports-ports (master):

fig2dev: fix getline on < 11

one missing header
does well on test suite

closes: #61905

[kencu (Ken)]

Thanks again!

[tloimer]

Replying to kencu:

I will pop in a patch while you consider adding that header to all builds, I presume.

Thanks!

Correct, the header is applied to fig2dev with commit ​a67d88.