fldigi port fails to rebuild

[mouse07410 (Mouse)]

macOS 10.15.7, Xcode-12.3.

Fails to build fldigi port:

$ sudo port rev-upgrade
--->  Scanning binaries for linking errors
--->  Found 2 broken files, matching files to ports      
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: fldigi @4.1.17+bundle
Continue? [Y/n]: y
--->  Computing dependencies for fldigi
--->  Cleaning fldigi
--->  Scanning binaries for linking errors
--->  Found 2 broken files, matching files to ports      
--->  Found 1 broken port, determining rebuild order
--->  Rebuilding in order
     fldigi @4.1.17 +bundle
--->  Computing dependencies for fldigi
--->  Fetching distfiles for fldigi
--->  Verifying checksums for fldigi
--->  Extracting fldigi
--->  Applying patches to fldigi
--->  Configuring fldigi
--->  Building fldigi
Error: Failed to build fldigi: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_fldigi/fldigi/main.log for details.
Error: rev-upgrade failed: Error rebuilding fldigi
Error: Follow https://guide.macports.org/#project.tickets to report a bug.

In the log file:

.  .  .  .  .
:info:build   CXX      flarq-src/flarq-xml_server.o
:info:build   CXX      dialogs/fldigi-htmlstrings.o
:info:build In file included from dialogs/htmlstrings.cxx:26:
:info:build ./dialogs/guide.cxx:1:26: warning: missing terminating '"' character [-Winvalid-pp-token]
:info:build const char* szBeginner = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\
:info:build                          ^
:info:build ./dialogs/guide.cxx:1:26: error: expected expression
:info:build ./dialogs/guide.cxx:740:12: warning: missing terminating '"' character [-Winvalid-pp-token]
:info:build   <div id=\"toctitle\">Table of Contents</div>
:info:build            ^
:info:build 2 warnings and 1 error generated.
:info:build make[1]: *** [dialogs/fldigi-htmlstrings.o] Error 1
:info:build make[1]: *** Waiting for unfinished jobs....
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_fldigi/fldigi/work/fldigi-4.1.17/src'
:info:build make: *** [appbundle] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_fldigi/fldigi/work/fldigi-4.1.17'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_fldigi/fldigi/work/fldigi-4.1.17" && /usr/bin/make -j4 -w appbundle
:info:build Exit code: 2
.  .  .  .  .

[mouse07410 (Mouse)]

fldigi/main.log

[ra1nb0w]

very weird error. I rebuild fldigi on my macOS 10.14 and it works fine. Downloaded the source from w1hkj and checked the syntax with cc -std=c++11 -fsyntax-only src/dialogs/guide.cxx and it is fine. Also it builds fine from the source.

Can you try the following commands

sudo port clean fldigi
sudo port -sn upgrade --force fldigi

[mouse07410 (Mouse)]

$ port installed fldigi
The following ports are currently installed:
  fldigi @4.1.17_0+bundle (active)
$ sudo port clean fldigi
Enter PIN for 'Certificate For PIV Authentication (Uri the Great)': 
--->  Cleaning fldigi
$ sudo port -sn upgrade --force fldigi
--->  Computing dependencies for fldigi
--->  Fetching distfiles for fldigi
--->  Verifying checksums for fldigi
--->  Extracting fldigi
--->  Applying patches to fldigi
--->  Configuring fldigi
--->  Building fldigi
Error: Failed to build fldigi: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_fldigi/fldigi/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
$ clang -v
Apple clang version 12.0.0 (clang-1200.0.32.28)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
$ 

From the log:

:info:build   CXX      dialogs/fldigi-htmlstrings.o
:info:build In file included from dialogs/htmlstrings.cxx:26:
:info:build ./dialogs/guide.cxx:1:26: warning: missing terminating '"' character [-Winvalid-pp-token]
:info:build const char* szBeginner = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\
:info:build                          ^
:info:build ./dialogs/guide.cxx:1:26: error: expected expression
:info:build ./dialogs/guide.cxx:740:12: warning: missing terminating '"' character [-Winvalid-pp-token]
:info:build   <div id=\"toctitle\">Table of Contents</div>
:info:build            ^
:info:build 2 warnings and 1 error generated.
:info:build make[1]: *** [dialogs/fldigi-htmlstrings.o] Error 1
:info:build make[1]: *** Waiting for unfinished jobs....

[mouse07410 (Mouse)]

Same when trying to compile manually:

.  .  .  .  .
  CXX      dialogs/fldigi-htmlstrings.o
In file included from dialogs/htmlstrings.cxx:26:
./dialogs/guide.cxx:1:26: warning: missing terminating '"' character [-Winvalid-pp-token]
const char* szBeginner = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\
                         ^
./dialogs/guide.cxx:1:26: error: expected expression
./dialogs/guide.cxx:740:12: warning: missing terminating '"' character [-Winvalid-pp-token]
  <div id=\"toctitle\">Table of Contents</div>
           ^
2 warnings and 1 error generated.
make[3]: *** [dialogs/fldigi-htmlstrings.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1
$ pwd
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_fldigi/fldigi/work/fldigi-4.1.17
$ 

There's also a ton of warnings - perhaps they are somehow related?

Also, mine is fldigi +bundle

[ra1nb0w]

Can you try to download ​http://www.w1hkj.com/files/fldigi/fldigi-4.1.17.tar.gz and build it manually?

tar xzvf fldigi-4.1.17.tar.gz && cd fldigi-4.1.17
./configure
make

thank you

[mouse07410 (Mouse)]

Same thing when I downloaded fldigi-4.1.17.tar.gz from ​http://www.w1hkj.com/files/fldigi/ and tried to build it:

mv -f dialogs/.deps/fldigi-font_browser.Tpo dialogs/.deps/fldigi-font_browser.Po
sed 's/\\/\\\\/g; s/"/\\"/g; s/$/\\n\\/g; 1 s/.*/const char* szBeginner = "&/; $ s/.*/&n";/' ../doc/guide.html > dialogs/guide.cxx
clang++ -DHAVE_CONFIG_H -I.  -DBUILD_FLDIGI -DLOCALEDIR=\"/opt/local/share/locale\" -I. -I./include -I./irrxml -I./libtiniconv -I./fileselector -I./xmlrpcpp -I./mbedtls -fno-stack-check -mmacosx-version-min=10.11 -DPKGDATADIR=\"/opt/local/share/fldigi\"    -I/opt/local/include -I/opt/local/include -I/opt/local/include -pipe -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT  -I/opt/local/include -I/opt/local/include  -D_THREAD_SAFE -pthread -I/opt/local/include -I/opt/local/include/libusb-1.0 -I/opt/local/include/libpng16 -I/opt/local/include       -pipe -Wall -fexceptions  -mavx2 -mfpmath=sse  -I./xmlrpcpp -fno-stack-check -mmacosx-version-min=10.11 -DNDEBUG    -march=native -O3 -std=gnu++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MT dialogs/fldigi-htmlstrings.o -MD -MP -MF dialogs/.deps/fldigi-htmlstrings.Tpo -c -o dialogs/fldigi-htmlstrings.o `test -f 'dialogs/htmlstrings.cxx' || echo './'`dialogs/htmlstrings.cxx
In file included from dialogs/htmlstrings.cxx:26:
./dialogs/guide.cxx:1:26: warning: missing terminating '"' character [-Winvalid-pp-token]
const char* szBeginner = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\
                         ^
./dialogs/guide.cxx:1:26: error: expected expression
./dialogs/guide.cxx:740:12: warning: missing terminating '"' character [-Winvalid-pp-token]
  <div id=\"toctitle\">Table of Contents</div>
           ^
2 warnings and 1 error generated.
make[3]: *** [dialogs/fldigi-htmlstrings.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1

[ra1nb0w]

This confirm that there is some other problem and it is not fldigi related since the syntax is correct. Unfortunately, I don't have any macOS 10.15 to try out.

Do you have custom environment variables or custom configurations on /opt/local/etc/macports?

Can you try cc -std=c++11 -Wall -fsyntax-only src/dialogs/guide.cxx from the sources?

[mouse07410 (Mouse)]

$ cc -std=c++11 -Wall -fsyntax-only src/dialogs/guide.cxx
src/dialogs/guide.cxx:1:26: warning: missing terminating '"' character [-Winvalid-pp-token]
const char* szBeginner = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\
                         ^
src/dialogs/guide.cxx:1:26: error: expected expression
src/dialogs/guide.cxx:740:12: warning: missing terminating '"' character [-Winvalid-pp-token]
  <div id=\"toctitle\">Table of Contents</div>
           ^
2 warnings and 1 error generated.
$ clang++-mp-11 -std=c++11 -Wall -fsyntax-only src/dialogs/guide.cxx
src/dialogs/guide.cxx:1:26: warning: missing terminating '"' character [-Winvalid-pp-token]
const char* szBeginner = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\
                         ^
src/dialogs/guide.cxx:1:26: error: expected expression
src/dialogs/guide.cxx:740:12: warning: missing terminating '"' character [-Winvalid-pp-token]
  <div id=\"toctitle\">Table of Contents</div>
           ^
2 warnings and 1 error generated.
$ env | grep CXXFLAGS
CXXFLAGS=-march=native -O3 -std=gnu++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk
$ 

No custom configuration in /opt/local/etc/macports, AFAIK.

Could you think of anything else I could/should look for?

[ra1nb0w]

You can try to install sudo port install clang-11 and check again with clang++-mp-11 -std=c++11 -Wall -fsyntax-only src/dialogs/guide.cxx.

At first sight seems a bug on Apple clang also because src/dialogs/guide.cxx was last modified in 2020-06-25 therefore before 4.1.14. Are you using fldigi before? or is it a new installation?

[mouse07410 (Mouse)]

I have clang-11 installed.

.  .  .  .  .
clang++-mp-11 -DHAVE_CONFIG_H -I.  -DBUILD_FLDIGI -DLOCALEDIR=\"/opt/local/share/locale\" -I. -I./include -I./irrxml -I./libtiniconv -I./fileselector -I./xmlrpcpp -I./mbedtls -fno-stack-check -mmacosx-version-min=10.11 -DPKGDATADIR=\"/opt/local/share/fldigi\"    -I/opt/local/include -I/opt/local/include -I/opt/local/include -pipe -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT  -I/opt/local/include -I/opt/local/include  -D_THREAD_SAFE -pthread -I/opt/local/include -I/opt/local/include/libusb-1.0 -I/opt/local/include/libpng16 -I/opt/local/include       -pipe -Wall -fexceptions  -mavx2 -mfpmath=sse  -I./xmlrpcpp -fno-stack-check -mmacosx-version-min=10.11 -DNDEBUG    -march=native -O3 -std=gnu++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MT dialogs/fldigi-htmlstrings.o -MD -MP -MF dialogs/.deps/fldigi-htmlstrings.Tpo -c -o dialogs/fldigi-htmlstrings.o `test -f 'dialogs/htmlstrings.cxx' || echo './'`dialogs/htmlstrings.cxx
In file included from dialogs/htmlstrings.cxx:26:
./dialogs/guide.cxx:1:26: warning: missing terminating '"' character [-Winvalid-pp-token]
const char* szBeginner = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\
                         ^
./dialogs/guide.cxx:1:26: error: expected expression
./dialogs/guide.cxx:740:12: warning: missing terminating '"' character [-Winvalid-pp-token]
  <div id=\"toctitle\">Table of Contents</div>
           ^
2 warnings and 1 error generated.
make[3]: *** [Makefile:5919: dialogs/fldigi-htmlstrings.o] Error 1

I don't know what caused this bug/problem to manifest - fldigi-4.1.17 was successfully Macports-installed around Dec 14th. Yes I've been using fldigi before, including this current version. Macports wants to rebuild it because of some changed dependency.

I get the same error with GCC10.

[ra1nb0w]

I have exhausted the ideas :( And I don't see any important changes on the ports log.

Maybe it is a C preprocessor problem (or cctools?) but probably the best thing to do is to contact w1hkj directly or through the mailing-list (​https://groups.io/g/linuxham).

[ra1nb0w]

Or try to mash-up the string in ./dialogs/guide.cxx like splitting and concatenating; comment out the text or double escaping the \n like \\n. Just to understand where is the problem. Should be easy if you know something about programming and C.

[mouse07410 (Mouse)]

I tried installing fldigi on a new machine - and got the same error. The problem only occurs when there's a local rebuild:

--->  Attempting to fetch fldigi-4.1.17_0+bundle.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/fldigi
--->  Installing fldigi @4.1.17_0+bundle
--->  Activating fldigi @4.1.17_0+bundle
--->  Cleaning fldigi
--->  Updating database of binaries
--->  Scanning binaries for linking errors
--->  Found 2 broken files, matching files to ports      
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: fldigi @4.1.17+bundle
Continue? [Y/n]: y
--->  Computing dependencies for fldigi
--->  Cleaning fldigi
--->  Scanning binaries for linking errors
--->  Found 2 broken files, matching files to ports      
--->  Found 1 broken port, determining rebuild order
--->  Rebuilding in order
     fldigi @4.1.17 +bundle
--->  Computing dependencies for fldigi
--->  Fetching distfiles for fldigi
--->  Attempting to fetch fldigi-4.1.17.tar.gz from http://www.w1hkj.com/files/fldigi/
--->  Verifying checksums for fldigi                                                 
--->  Extracting fldigi
--->  Applying patches to fldigi
--->  Configuring fldigi
--->  Building fldigi
Error: Failed to build fldigi: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_fldigi/fldigi/main.log for details.
Error: rev-upgrade failed: Error rebuilding fldigi
Error: Follow https://guide.macports.org/#project.tickets to report a bug.

Nonetheless, the above leaves an apparently-usable fldigi binary, with one problem (different version of hamlib):

$ port installed fldigi
The following ports are currently installed:
  fldigi @4.1.17_0+bundle (active)
$ type fldigi
fldigi is /opt/local/bin/fldigi
$ fldigi
dyld: Library not loaded: /opt/local/lib/libhamlib.2.dylib
  Referenced from: /opt/local/bin/fldigi
  Reason: image not found
zsh: abort      fldigi
$ port installed hamlib
The following ports are currently installed:
  hamlib @4.0_0 (active)
$ ll /opt/local/lib/libhamlib*
-rwxr-xr-x  1 root  admin  8181420 Dec 30 05:33 /opt/local/lib/libhamlib.4.dylib*
-rw-r--r--  1 root  admin  9417104 Dec 30 05:33 /opt/local/lib/libhamlib.a
lrwxr-xr-x  1 root  admin       17 Dec 30 05:33 /opt/local/lib/libhamlib.dylib@ -> libhamlib.4.dylib
$
$ sudo install_name_tool -change /opt/local/lib/libhamlib.2.dylib /opt/local/lib/libhamlib.dylib /opt/local/bin/fldigi
Enter PIN for '<myself>': 
$ fldigi                      
E: [14:13:10] soundcard/sound.cxx : 1812 : init_stream
    Could not find device "", using default device
I: [14:13:10] soundcard/sound.cxx : 1925 : start_stream
    
open pa stream for read:
  samplerate    : 48000
  device number : 0
  # channels    : 1
  latency       : 0.043854
  sample Format : paFloat32
I: [14:13:10] soundcard/sound.cxx : 1388 : Open
    Port Audio open mode = Read
device type = paInDevelopment
.  .  .  .  .

Changing "\n" to "\\n" did not lead to success - same silly compile error. Will try commenting out the text altogether, and splitting+concatenating next.

[ra1nb0w]

That was the previous fldigi binary. The rebuild is because hamlib team has released the 4 version (major update).

I triggered a macports rebuild of fldigi to check issues on cleared macOS system. It builds fine on all system except on 10.7 for a dependency issue (10.15 log ​https://build.macports.org/builders/ports-10.15_x86_64-builder/builds/46762/steps/install-port/logs/stdio). Have you tried to use XCode 11.7 or a 11 series? and before that try to uninstall everything sudo port uninstall fltk hamlib fldigi portaudio

[mouse07410 (Mouse)]

I triggered a macports rebuild of fldigi to check issues on cleared macOS system

When can we hope to see the new binaries replacing the current fldigi port in the repos? I hope that would solve my problem by avoiding local rebuild.

Have you tried to use XCode 11.7 or a 11 series? and before that try to uninstall everything sudo port uninstall fltk hamlib fldigi portaudio

I don't have Xcode-11.7, and probably won't be allowed to install it (our IT security prohibits installing old versions).

Based on the following, all the new dependencies were not present before the installation, and got installed first.

$ sudo port install fldigi
--->  Computing dependencies for fldigi
The following dependencies will be installed: 
 flac
 fltk
 hamlib
 libsamplerate
 libsndfile
 libusb-compat
 portaudio
Continue? [Y/n]: y
--->  Fetching archive for fltk
--->  Attempting to fetch fltk-1.3.5_0.darwin_19.x86_64.tbz2 from https://packages.macports.org/fltk
--->  Attempting to fetch fltk-1.3.5_0.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/fltk
--->  Installing fltk @1.3.5_0
--->  Activating fltk @1.3.5_0
--->  Cleaning fltk
--->  Fetching archive for libusb-compat
--->  Attempting to fetch libusb-compat-0.1.7_0.darwin_19.x86_64.tbz2 from https://packages.macports.org/libusb-compat
--->  Attempting to fetch libusb-compat-0.1.7_0.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/libusb-compat
--->  Installing libusb-compat @0.1.7_0
--->  Activating libusb-compat @0.1.7_0
--->  Cleaning libusb-compat
--->  Fetching archive for hamlib
--->  Attempting to fetch hamlib-4.0_0.darwin_19.x86_64.tbz2 from https://packages.macports.org/hamlib
--->  Attempting to fetch hamlib-4.0_0.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/hamlib
--->  Installing hamlib @4.0_0
--->  Activating hamlib @4.0_0
--->  Cleaning hamlib
--->  Fetching archive for flac
--->  Attempting to fetch flac-1.3.3_0.darwin_19.x86_64.tbz2 from https://packages.macports.org/flac
--->  Attempting to fetch flac-1.3.3_0.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/flac
--->  Installing flac @1.3.3_0
--->  Activating flac @1.3.3_0
--->  Cleaning flac
--->  Fetching archive for libsndfile
--->  Attempting to fetch libsndfile-1.0.28_1.darwin_19.x86_64.tbz2 from https://packages.macports.org/libsndfile
--->  Attempting to fetch libsndfile-1.0.28_1.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/libsndfile
--->  Installing libsndfile @1.0.28_1
--->  Activating libsndfile @1.0.28_1
--->  Cleaning libsndfile
--->  Fetching archive for libsamplerate
--->  Attempting to fetch libsamplerate-0.1.9_1.darwin_19.x86_64.tbz2 from https://packages.macports.org/libsamplerate
--->  Attempting to fetch libsamplerate-0.1.9_1.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/libsamplerate
--->  Installing libsamplerate @0.1.9_1
--->  Activating libsamplerate @0.1.9_1
--->  Cleaning libsamplerate
--->  Fetching archive for portaudio
--->  Attempting to fetch portaudio-19.20161030_0.darwin_19.x86_64.tbz2 from https://packages.macports.org/portaudio
--->  Attempting to fetch portaudio-19.20161030_0.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/portaudio
--->  Installing portaudio @19.20161030_0
--->  Activating portaudio @19.20161030_0
--->  Cleaning portaudio
--->  Fetching archive for fldigi
--->  Attempting to fetch fldigi-4.1.17_0+bundle.darwin_19.x86_64.tbz2 from https://packages.macports.org/fldigi
--->  Attempting to fetch fldigi-4.1.17_0+bundle.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/fldigi
--->  Installing fldigi @4.1.17_0+bundle
--->  Activating fldigi @4.1.17_0+bundle
--->  Cleaning fldigi
--->  Updating database of binaries
--->  Scanning binaries for linking errors
--->  Found 2 broken files, matching files to ports      
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: fldigi @4.1.17+bundle
Continue? [Y/n]: y
--->  Computing dependencies for fldigi
--->  Cleaning fldigi
--->  Scanning binaries for linking errors
--->  Found 2 broken files, matching files to ports      
--->  Found 1 broken port, determining rebuild order
--->  Rebuilding in order
     fldigi @4.1.17 +bundle
--->  Computing dependencies for fldigi
--->  Fetching distfiles for fldigi
--->  Attempting to fetch fldigi-4.1.17.tar.gz from http://www.w1hkj.com/files/fldigi/
--->  Verifying checksums for fldigi                                                 
--->  Extracting fldigi
--->  Applying patches to fldigi
--->  Configuring fldigi
--->  Building fldigi
Error: Failed to build fldigi: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_fldigi/fldigi/main.log for details.
Error: rev-upgrade failed: Error rebuilding fldigi
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
$ port installed fldigi
The following ports are currently installed:
  fldigi @4.1.17_0+bundle (active)
$ 

[ra1nb0w]

The binary is already available: sudo port -b install fldigi

[mouse07410 (Mouse)]

Thank you!!

[raimue (Rainer Müller)]

While the binary archive is available, the build issue seems to persist for users compiling from source locally. Today it was reported again ​by a user on IRC with Xcode 12.4.

Maybe we need to deny use of this compiler from Xcode 12.x with compiler.blacklist?

[ra1nb0w]

I will discuss the error with the fldigi's main developer.

Thank you to hare reported the issue.

[Davide Gerhard <ra1nb0w@…>]

In 10a47890932bf73b32243bad738b228068658e9f/macports-ports (master):

fldigi: fix non unix newline char

see bug ​https://github.com/asciidoc/asciidoc-py3/issues/154

Closes: #61945

[ra1nb0w]

Now, should be fixed. Report back if not.

[mouse07410 (Mouse)]

Maybe we need to deny use of this compiler from Xcode 12.x

No!

What you need to make it build-able is:

• ensure asciidoc is at least v10.0.0a2 - otherwise you'll get ^M in a few files
• enforce -std=c++11 - otherwise (e.g., with -std=gnu++17, as I usually have) you'll get set_unexpected() undefined
• enforce -mmacosx-version-min=10.11 or such, as this build fails with -mmacosx-version-min=10.6 or whatever

Then it builds fine with Xcode-12.4.

[ra1nb0w]

It is already fixed in macports. Sync it. If you manually build it you need only asciidoc >= 9.0.5 (already available on macports). The others are custom configurations of one reporter. Avoid it.

[mouse07410 (Mouse)]

It is already fixed in macports

Would you mind telling what exactly the fix was?

If you manually build it you need only asciidoc >= 9.0.5 (already available on macports).

In my experience, it did not build from the source until I installed asciidoc 10.0.0a2. But I did not try 9.0.5 - whatever was in Macports back then.

The others are custom configurations of one reporter. Avoid it.

I don't think you're correct. And I'm that "one reporter", thank you.

[ra1nb0w]

The fix is in the following patch ​https://github.com/asciidoc/asciidoc-py3/pull/155 that it is available with asciidoc 9.0.5 (~10 is a pre-release). Then I forced fldigi to rebuild docs with the newer asciidoc (I also updated asciidoc to 9.0.5).

Do you confirm that the problem goes away in macports after syncing with macOS 10.15 and Xcode 12?

as I usually have seems clear to me that this change is related to your custom configuration and therefore should be underlined. Sorry if I was too crude. Anyway, you can see all changes that I did to make fldigi working also with old macOS versions (>= 10.6 if remember well) at ​https://github.com/macports/macports-ports/blob/master/science/fldigi/Portfile

[mouse07410 (Mouse)]

Do you confirm that the problem goes away in macports after syncing with macOS 10.15 and Xcode 12?

Yes I confirm that.

seems clear to me that this change is related to your custom configuration and therefore should be underlined

I much doubt that. Not to mention that I don't have a custom configuration.

I think the main problem was due the broken asciidoc in Macports. Also, fldigi port seems to have -mmacosx-version-min=10.11 flag, the same as I found necessary when building straight from the sources without Macports patches or config.

[ra1nb0w]

The bug was in asciidoc but since fldigi contains wrong generated files we need to "force" the rebuild of those files with the config parameter --with-asciidoc.