thrift @0.13.0 build fails with undefined symbols on Big Sur

[fgunbin]

I'm getting this build error on macOS 11.2.1

Also I see here ​https://ports.macports.org/port/thrift/builds that build status is red for 11_x86_64.

:info:build Undefined symbols for architecture x86_64:
:info:build   "apache::thrift::concurrency::Thread::threadMain(std::__1::shared_ptr<apache::thrift::concurrency::Thread>)", referenced from:
:info:build       apache::thrift::concurrency::Thread::start() in libthriftnb_la-TNonblockingServer.o

:info:build   "apache::thrift::GlobalOutput", referenced from:
:info:build       apache::thrift::server::TNonblockingServer::TConnection::workSocket() in libthriftnb_la-TNonblockingServer.o
:info:build       apache::thrift::server::TNonblockingServer::TConnection::transition() in libthriftnb_la-TNonblockingServer.o
:info:build       apache::thrift::server::TNonblockingServer::TConnection::setFlags(short) in libthriftnb_la-TNonblockingServer.o
:info:build       apache::thrift::server::TNonblockingServer::handleEvent(int, short) in libthriftnb_la-TNonblockingServer.o

<and more of that>

I see this in the beginning of log (full log attached):

:warn:main The macOS 11.2 SDK does not appear to be installed. Ports may not build correctly.
:warn:main You can install it as part of the Xcode Command Line Tools package by running `xcode-select --install'.

I've reinstalled command line tools by removing /Library/Developer/CommandLineTools and running xcode-select as suggested, but the warning won't go away.

[fgunbin]

log

[ryandesign (Ryan Carsten Schmidt)]

Replying to fgunbin:

I see this in the beginning of log (full log attached):

:warn:main The macOS 11.2 SDK does not appear to be installed. Ports may not build correctly.
:warn:main You can install it as part of the Xcode Command Line Tools package by running `xcode-select --install'.

I've reinstalled command line tools by removing /Library/Developer/CommandLineTools and running xcode-select as suggested, but the warning won't go away.

Ignore that with this version of MacPorts or install MacPorts from git master. See ​https://lists.macports.org/pipermail/macports-users/2021-February/049530.html

[ryandesign (Ryan Carsten Schmidt)]

This looks like the well-known libtool macOS 11+ undefined symbols bug. Probably just needs the standard fix per the patch in the libtool port's files dir.

[ryandesign (Ryan Carsten Schmidt)]

On second thought, it's not that easy, since the port already regenerates the configure script, so it would already contain the fixes from the libtool port.

[ryandesign (Ryan Carsten Schmidt)]

This port has a local copy of libtool.m4 which it uses instead of the fixed one from the libtool port.

[ryandesign (Ryan Carsten Schmidt)]

In dbfc06c047b3f6f9c1df7924b0afa7539cfd9d88/macports-ports (master):

thrift: Apply the macOS 11+ libtool bugfix

Closes: #62274

[fgunbin]

Thank you for the fix!