py37-dns-lexicon depends on py38 packages

[LucaFilipozzi (Luca Filipozzi)]

This py37 package depends on py38 packages: poetry and py38-lockfile.

--->  Computing dependencies for py37-dns-lexicon
The following dependencies will be installed:
 poetry
 py38-lockfile
Continue? [Y/n]:

[reneeotten (Renee Otten)]

this happens because these are dependencies of the build-dependency poetry, which uses Python 3.8. I don't think there is anything to change/fix here, but I'll leave it to Marius to close this ticket if he agrees.

[mf2k (Frank Schima)]

In the future, please use WikiFormatting.

[Schamschula (Marius Schamschula)]

No, this shouldn't happen. I can reproduce this.

The active_variants PG should ask for the correct poetry variant.

[Schamschula (Marius Schamschula)]

The problem is that the poetry variant has to be the same version as py-poetry-core. If there is a mismatch, the build fails.

One reason I hate that we install python binaries as a variant, rather than as pyXX-package. This would remove the need for the Port Group.

That said, I have poetry +python39 installed. If I try to install py38-dns-lexicon, I get

Error: Failed to configure py38-dns-lexicon: poetry must be installed with +python38.
Error: See /opt/local/var/macports/logs/_Users_marius_Development_MacPorts_ports_python_py-dns-lexicon/py38-dns-lexicon/main.log for details.

as expected.

[LucaFilipozzi (Luca Filipozzi)]

When I opened this ticket, I opened ticket:62296 against poetry asking that it be installable as pyXX-package.

[Schamschula (Marius Schamschula)]

That's unlikely to happen. MacPorts on uses pyXX-package for libraries, not Python executables. I've been through that with a couple packages I maintain.

[Schamschula (Marius Schamschula)]

Of course there are other edge cases like pyXX-sphinx.

[jmroot (Joshua Root)]

If it's a module that is imported by other things, it should be py-poetry. Whether it also installs executables is not really relevant.

[dgilman (David Gilman)]

I'd argue that this is a packaging problem with dns-lexicon itself. The .tar.gz available on pypi has a setup.py that doesn't appear to use poetry, unless I am mistaken. Is it somehow inappropriate to use the distfile from pypi for building this?

[Schamschula (Marius Schamschula)]

Unfortunately, that doesn't work! All you get is an unusable package with a handful of placeholder files.

This why there is an epoch set in this Portfile. The upgrade to version 3.4.x and above completely broke the default install method, as the package now requires pep517 (which was not supported by the python PG at the time), along with poetry. I temporarily reverted to version 3.3.28 that could be installed using the old method. See my commits for December 1st, 2020 and January 5th 2021. I had a lengthy discussion with the upstream maintainers about this issue.

[LucaFilipozzi (Luca Filipozzi)]

Even if this were an issue with dns-lexicon (sure, contact upstream for possible resolution), poetry using variants rather than version-specific packages is problematic, in my view.

[Schamschula (Marius Schamschula)]

For the record, here is the upstream issue ​https://github.com/AnalogJ/lexicon/issues/568