xorg-server-legacy-1.20.10_0: build errors on 10.5 Leopard Intel

[kencu (Ken)]

working my way down the systems. 10.6 was fixed quite easily with the legacysupport PG for strnlen (and others?).

10.5 Intel fails with this:

:info:build quartz.c:379:9: error: implicit declaration of function 'xp_disable_hot_keys' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build         xp_disable_hot_keys(XQuartzFullscreenVisible);
:info:build         ^

I fixed that with the patch attached, and then another dangling use of something that was related to libdispatch was patched out as well with the next patch.

And with that, it built, and seems to work, although I'm not sure how to test the hotkeys thing exactly. I may not have done it 100% as it should be, so will put here for thoughts before pushing.

After this comes 10.5 PPC and then Tiger.

[kencu (Ken)]

hw/xquartz/quartz.c

@@ -374 +374 @@
     X11ApplicationShowHideMenubar(!XQuartzFullscreenVisible);
 
     xp_reenable_update();
-
-    if (XQuartzFullscreenDisableHotkeys)
-        xp_disable_hot_keys(XQuartzFullscreenVisible);
 }
 
 void
@@ -407 +404 @@
     X11ApplicationShowHideMenubar(TRUE);
 
     xp_reenable_update();
-
-    xp_disable_hot_keys(FALSE);
 }
 
 /*

[kencu (Ken)]

hw/xquartz/X11Application.m

@@ -312 +312 @@
     /* Don't try sending to X if we haven't initialized.  This can happen if AppKit takes over
      * (eg: uncaught exception) early in launch.
      */
+
+#ifdef HAVE_LIBDISPATCH
     if (!eventTranslationQueue) {
         [super sendEvent:e];
         return;
     }
+#endif
 
     OSX_BOOL for_appkit, for_x;
 

[jeremyhu (Jeremy Huddleston Sequoia)]

In bc3b072cfd3a9816ada5f392a1d0afd55c158f40/macports-ports (master):

xorg-server-legacy: Addrese a build failure on Tiger and Leopard

Fixes: #62477
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@…>