saml2aws: cannot find package "github.com/versent/saml2aws/v2/cmd/saml2aws/commands" in any of:

[ryandesign (Ryan Carsten Schmidt)]

saml2aws doesn't build on any buildbot builder:

​https://build.macports.org/builders/ports-11_x86_64-builder/builds/30711/steps/install-port/logs/stdio

cmd/saml2aws/main.go:13:2: cannot find package "github.com/versent/saml2aws/v2/cmd/saml2aws/commands" in any of:
	/opt/local/lib/go/src/github.com/versent/saml2aws/v2/cmd/saml2aws/commands (from $GOROOT)
	/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_saml2aws/saml2aws/work/gopath/src/github.com/versent/saml2aws/v2/cmd/saml2aws/commands (from $GOPATH)
cmd/saml2aws/main.go:14:2: cannot find package "github.com/versent/saml2aws/v2/pkg/flags" in any of:
	/opt/local/lib/go/src/github.com/versent/saml2aws/v2/pkg/flags (from $GOROOT)
	/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_saml2aws/saml2aws/work/gopath/src/github.com/versent/saml2aws/v2/pkg/flags (from $GOPATH)
Command failed:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_saml2aws/saml2aws/work/gopath/src/github.com/Versent/saml2aws" && /opt/local/bin/go build -trimpath -ldflags "-s -w -X main.Version=2.30.0" ./cmd/saml2aws 
Exit code: 1

Comments on [bc53423fcbb07af94ca474bf3b1b2fa0d1e2748d/macports-ports] mention the problem is a difference in case between "Versent" and "versent".

[jamesog (James O'Gorman)]

I believe this PR should fix it: ​https://github.com/macports/macports-ports/pull/11117

I created a case-sensitive APFS volume, moved my portdbpath there and ran the build both with and without the go.package fix.

[jamesog (James O'Gorman)]

In 8b2f1b5581bedbdf55fe8a13c2af03a9704ffc3e/macports-ports (master):

saml2aws: Fix build on case-sensitive filesystems

The saml2aws project is under GitHub author Versent, but the program is
using import paths of github.com/versent. This works on case-insensitive
filesystems (the default for HFS+ and APFS) but fails on case-sensitive
filesystems, such as the MacPorts Buildbots.

Fixes: #62928

[jamesog (James O'Gorman)]

In 90e2fa5294a423c9d512400249308a501f519c86/macports-ports (master):

saml2aws: Mark as unsupported on < 10.9

The github.com/keybase/go-keychain dependency requires at least OS X
10.9. Buildbots for older OS X versions are currently failing builds
because of this.

Set the known_fail flag so Buildbots skip the build per Ryan [1], and
display an error at pre-fetch notifying that the OS isn't supported.

[1] ​https://lists.macports.org/pipermail/macports-dev/2020-October/042480.html

Refs: #62928

[jamesog (James O'Gorman)]

Hi Ryan,

In 8b2f1b5581bedbdf55fe8a13c2af03a9704ffc3e/macports-ports I added a block to try and skip builds on older macOS versions, but from looking at BuildBot builds, I'm wondering if it has skipped builds on all versions instead.

Are you able to help check if that's really what happened, please?

Thank you.

[ryandesign (Ryan Carsten Schmidt)]

The change looks correct to me. Buildbot will of course skip builds that have already happened successfully.

[jamesog (James O'Gorman)]

Ah, that makes sense! Thanks for confirming.