nautilus @3.24.2.1_6 needs to require_active_variants gdk-pixbuf2 x11

[cooljeanius (Eric Gallager)]

Attempting to install nautilus fails for me with this error:

eel-gdk-extensions.c:31:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
         ^~~~~~~~~~~~
1 error generated.
make[2]: *** [eel-gdk-extensions.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
eel-gtk-extensions.c:37:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
         ^~~~~~~~~~~~
1 error generated.
make[2]: *** [eel-gtk-extensions.lo] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_nautilus/nautilus/work/nautilus-3.24.2.1/eel'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_nautilus/nautilus/work/nautilus-3.24.2.1'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_nautilus/nautilus/work/nautilus-3.24.2.1'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_nautilus/nautilus/work/nautilus-3.24.2.1" && /usr/bin/make -j16 -w all CFLAGS="-Os -pipe -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64" LDFLAGS="-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64" 
Exit code: 2
Error: Failed to build nautilus: command execution failed
DEBUG: Error code: CHILDSTATUS 99983 2

I am pretty sure this header only gets installed when gdk-pixbuf2 is installed with the +x11 variant active. I am trying to install as many gtk-based ports as I can with +quartz and -x11, so I do not currently have that header. MacPorts should error out earlier with an active_variants check to make it clearer why installing Nautilus won't work if your gtk-based ports are installed +quartz and -x11. (Note: some of the wording for this bug copied from bug #62366 for AfterStep)

[cooljeanius (Eric Gallager)]

oh wait, it looks like nautilus doesn't even depend on gdk-pixbuf2 after all? Maybe the active_variants check needs to be against gtk3 instead?

[cooljeanius (Eric Gallager)]

Replying to cooljeanius:

oh wait, it looks like nautilus doesn't even depend on gdk-pixbuf2 after all? Maybe the active_variants check needs to be against gtk3 instead?

I opened the following PR that does the check against gtk3 instead: ​https://github.com/macports/macports-ports/pull/11696

[cooljeanius (Eric Gallager)]

In b06c236211d400c4a3206187c17c3c345c7a8cde/macports-ports (master):

nautilus: require +x11 variant for gtk3

Closes: #62947
(I'm also adding a size checksum while I'm at it)