llvm-12: base generates warnings about -Wimplicit-function-declaration

[ceandrade (Carlos Eduardo de Andrade)]

It looks like the version of clang included with Xcode 12 and later has complained about code with implicit function declarations (when you use the function before declaring it). A similar "bug" has been reported to other packages. You may find the full explanation here: ​https://www.mail-archive.com/macports-users@lists.macports.org/msg07685.html

This is my log:

$ sudo port selfupdate
Password:
--->  Updating MacPorts base sources using rsync
MacPorts base version 2.7.1 installed,
MacPorts base version 2.7.1 downloaded.
--->  Updating the ports tree
--->  MacPorts base is already the latest version

The ports tree has been updated. To upgrade your installed ports, you should run
  port upgrade outdated

$ sudo port -N upgrade outdated
--->  Computing dependencies for llvm-12
--->  Fetching archive for llvm-12
--->  Attempting to fetch llvm-12-12.0.0_1.darwin_20.x86_64.tbz2 from https://packages.macports.org/llvm-12
--->  Attempting to fetch llvm-12-12.0.0_1.darwin_20.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/llvm-12
--->  Attempting to fetch llvm-12-12.0.0_1.darwin_20.x86_64.tbz2 from https://mse.uk.packages.macports.org/llvm-12
--->  Fetching distfiles for llvm-12
--->  Verifying checksums for llvm-12
--->  Extracting llvm-12
--->  Applying patches to llvm-12
--->  Configuring llvm-12
Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled:
  _stricmp: found in build/CMakeFiles/CMakeError.log
  _snprintf: found in build/CMakeFiles/CMakeError.log
  _strnicmp: found in build/CMakeFiles/CMakeError.log
--->  Building llvm-12
Error: Failed to build llvm-12: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_llvm-12/llvm-12/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.

Thanks,

Carlos

[ceandrade (Carlos Eduardo de Andrade)]

Build log

[kencu (Ken)]

I imagine cmake is just testing for the existence of certain functions here, and not finding them.

This is expected in these cases, so this is a "false positive".

Ryan had some method to whitelist ports from this check...I don't understand that, but perhaps he might volunteer some fix for the MacPorts warning.

[kencu (Ken)]

the actual build error you saw was due to #63110, which was just fixed.

[ceandrade (Carlos Eduardo de Andrade)]

OK, thanks @kencu! I'll follow the developments there.