litmus @0.13_2: configure: error: could not find library containing socket

[cooljeanius (Eric Gallager)]

I'm on Big Sur (11.4) with Xcode 12.5.1:

checking whether stpcpy is declared... yes
checking for library containing socket... not found
configure: error: could not find library containing socket
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_litmus/litmus/work/litmus-0.13" && ./configure --prefix=/opt/local --with-expat --with-ssl=openssl 
Exit code: 1
Error: Failed to configure litmus: consult /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_litmus/litmus/work/litmus-0.13/config.log
Error: Failed to configure litmus: configure failure: command execution failed
DEBUG: Error code: NONE
DEBUG: Backtrace: configure failure: command execution failed
    while executing
"$procedure $targetname"
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_litmus/litmus/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port litmus failed

config.log says:

configure:7383: /usr/bin/clang -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64 -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -no-cpp-precomp -L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64 -flat_namespace conftest.c  >&5
conftest.c:100:1: error: implicit declaration of function 'socket' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
socket();
^
1 error generated.

...so IOW it looks like another victim of -Werror=implicit-function-declaration being on by default now. Looking at the m4 macros in this port's source, it looks like it uses macros from neon, and the neon port had a similar bug (bug #61483), so the fix for that one could probably be brought over to this one.

[ryandesign (Ryan Carsten Schmidt)]

It's not clear to me why Marcus fixed that one by declaring fake prototypes for the various system functions, rather than by including the system headers that declare the real prototypes.

[ryandesign (Ryan Carsten Schmidt)]

I've tried to fix the underlying problem in neon.

​https://github.com/notroj/neon/pull/57

Since litmus should be using MacPorts neon, it should not need to be doing these checks in its own configure script. Maybe let's remove them.

In fact, litmus isn't using MacPorts neon because it is looking specifically for versions less than 0.31 and we now have neon 0.31.2, so that will need to be fixed as well along with a revbump.

[ryandesign (Ryan Carsten Schmidt)]

These bad configure checks are only being invoked because it didn't find a compatible MacPorts neon version, so fixing that will eliminate the use of the bad configure checks.

[ryandesign (Ryan Carsten Schmidt)]

[09ad005b23334856812ada84927884edc6fb7bf8/macports-ports]