Opened 3 years ago

Last modified 21 months ago

#63664 new request

libfive now requires macOS 10.15 when built with Eigen 3.4; new maintainer needed

Reported by: szhorvat (Szabolcs Horvát) Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cjones051073 (Chris Jones), mascguy (Christopher Nielsen)
Port: libfive

Description

tl;dr libfive now seems to require macOS 10.15, which means I can't maintain it as I don't have 10.15. I can't remove myself as maintainer either without causing damage, looking for someone to help sort the situation out.


Some time ago I contributed the libfive port:

https://libfive.com/ https://github.com/macports/macports-ports/tree/master/graphics/libfive

libfive depends on the Eigen library, and unfortunately the fix that was applied to libfive to make it compatible with Eigen 3.4.0 only works on macOS 10.15 or later. I am stuck on macOS 10.14, so I cannot continue maintaining this port. Therefore, I would like to be removed as a maintainer, and I hope that someone who has access to 10.15+ will keep it working and up to date.

I did not submit a PR to remove myself as a maintainer, as this would trigger a re-build, which would fail due to Eigen having been updated to 3.4.0 in MacPorts. I could update libfive to a later commit to make it compatible with Eigen 3.4.0, but I'd have to do it "blind", as I can't test it (no access to macOS 10.15). This is why I chose to open this issue, in the hope that someone will be so kind to sort it out.

Normally, backwards compatibility issues can be sorted out using legacy-support. It seems to me that this is not going to be possible here, but I'm not sure, hence CC'ing Chris Jones. The problem is that aligned_alloc is only available on macOS 10.15 or newer. aligned_alloc seems to be provided by the OS, not by the compiler, so using Clang from MacPorts (instead of Apple Clang) does not help. I'm not sure GCC is okay to use unless all the dependencies are also compiled with GCC (either way, compilation fails with GCC).

For more information about what changed in libfive, see this comment on GitHub and below:

https://github.com/libfive/libfive/issues/462#issuecomment-950137570

Change History (3)

comment:1 Changed 3 years ago by cjones051073 (Chris Jones)

please just submit a PR making it nomaintainer. A rebuild will not be triggered unless you bump the revision which is not required.

comment:2 Changed 3 years ago by szhorvat (Szabolcs Horvát)

In 7d9563dcd585aaf9dea85930383593a9ef041468/macports-ports (master):

libfive: remove maintainer

comment:3 Changed 21 months ago by mascguy (Christopher Nielsen)

Cc: mascguy added
Note: See TracTickets for help on using tickets.