serf1: error: implicit declaration of function 'ERR_GET_FUNC'

[DetmarM (Detmar Meurers)]

build of serf1 @1.3.9_3 in MacPorts 2.7.1 using Xcode 13.1 fails because of

buckets/ssl_buckets.c:1329:24: error: implicit declaration of function 'ERR_GET_FUNC' [-Werror,-Wimplicit-function-declaration]

Full log is attached. Would be great to get a fix since this also means subversion won't build.

[DetmarM (Detmar Meurers)]

/opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_serf1/serf1/main.log

[ryandesign (Ryan Carsten Schmidt)]

Undoubtedly fallout from the recent switch to openssl 3.

Port has no maintainer; fixes welcome.

[jmroot (Joshua Root)]

ERR_GET_FUNC is gone in openssl 3. ​https://www.openssl.org/news/changelog.html#openssl-30

[reneeotten (Renee Otten)]

I fixed that yesterday already in this commit so unless the openssl3 PR undid these changes it should work already... Let me take a look.

[reneeotten (Renee Otten)]

ah, well it does add the correct include directory for openssl11 but that one comes after ${prefix}/include, so I guess that is the issue here... Likely the order needs to be changed, I don't know from the top of my head how to do that in general, but certainly not with Scons, but perhaps someone else does. For now as a workaround you can build it in trace-mode locally or wait until it's build by the buildbot as there only the openssl11 dependency will be installed.

[czo]

I've submitted a pull-request to modify the directory ordering in the SConstruct file, to include openssl directories before the macports-wide directories are listed in (ie changing 'append' to 'prepend'). ​https://github.com/macports/macports-ports/pull/12860

[czo]

In cf8552519f6ae862957c0ed56fe16df922548a97/macports-ports (master):

serf1: fix openssl include path preference

Closes: #63852