edbrowse: Update to 3.8.0

[ssb22 (Silas S. Brown)]

The port version of edbrowse is 3.4.10, but upstream is 3.8.0 with quite a bit of new functionality.

I was able to compile upstream directly as follows:

sudo port install pcre curl tidy gsed gmake &&
git clone https://github.com/bellard/quickjs &&
make -C quickjs && sudo make -C quickjs install &&
git clone https://github.com/CMB/edbrowse &&
cd edbrowse/src &&
sed -e 's/else sed -f/else gsed -f/' -e 's/-latomic//' < makefile > makefile.new &&
gmake -f makefile.new CFLAGS="-I /opt/local/include" &&
sudo mv edbrowse /usr/local/bin

[ryandesign (Ryan Carsten Schmidt)]

Feel free to submit a pull request to update the port as needed. The port has no maintainer.

[ssb22 (Silas S. Brown)]

Thanks. It won't be a simple pull request because upstream has moved from spidermonkey to quickjs, and there isn't a port of quickjs. Is it OK to bundle quickjs with the edbrowse port, or should we add a quickjs port separately? (does that need to go through an approvals process for new ports?)

[ryandesign (Ryan Carsten Schmidt)]

Often adding a separate port for a dependency is simpler and more desirable. (MacPorts does not easily accommodate a single port needing to run multiple different configure scripts and multiple different make sessions, for example.) There is no approval process as such; just submit a pull request for the new port. It will be reviewed for any possible needed changes before being merged.

On the other hand, the quickjs web site says it is "small and embeddable". If edbrowse has chosen to embed quickjs, i.e. if a copy of quickjs is bundled with edbrowse and the edbrowse build system automatically builds the bundled quickjs with the same cflags/cxxflags/ldflags used to build edbrowse and edbrowse links with it as a static library, then there's no harm having the edbrowse port do it that way.

[ryandesign (Ryan Carsten Schmidt)]

The ​edbrowse readme (now, as of 3.8.2) says:

quickjs:
This is the javascript engine for edbrowse.
It is probably not packaged.
Even if it is, you have to build it from source to mesh with edbrowse.

So that answers that: Even if we had quickjs as a port in MacPorts, which we still don't, edbrowse still wants a separately-compiled version (because they make a small patch to the library)—but its build system doesn't do it for us so I'll update the edbrowse port to do this.

[ryandesign (Ryan Carsten Schmidt)]

In d25f140b0e34e001f753211acac9e45ee4803069/macports-ports (master):

edbrowse: Update to 3.8.2.1

Closes: #63982