advancemame build fail on Mountain Lion

[chillin-]

I'm not really sure what the trouble is, but Ryan took a look at the log and said:

On Mac OS X 10.6-10.8, the default C++ stdlib is libstdc++ but MacPorts enforces the use of libc++ for greater compatibility with newer software. Successful enforcement requires the build system to use the CXXFLAGS MacPorts tells it to use. Evidently advancemame's build system has a bug where it does not do that. We'll need to find where and fix it. This problem would not be seen on OS X 10.9 or later which default to libc++ already.

[chillin-]

this is output of port -d -t rev-upgrade |tee advancemame_buildfail.txt

[chillin-]

Note: advancemame built successfully initially... the fail occurs on update. when output of port outdated is

  advancemame                    3.9_0 < 3.9_0  (C++ stdlib libstdc++ != libc++)

[ryandesign (Ryan Carsten Schmidt)]

So you're reporting two separate unrelated things:

1. When the port used to build, it used the wrong C++ stdlib on 10.6-10.8
2. The port now doesn't build because configure: error: no video library found. If you have the SDL library installed somewhere try using the --with-sdl-prefix or --with-sdl2-prefix options

[chillin-]

When the port used to build

This was last week, not months or years ago. I even want to assume if I uninstalled and reinstalled macports on this 10.8 system, advancemame would build successfully, but then still choke on that update afterwards. I don't want to go too far off topic here, but when building a number of ports, the order the ports are built sometimes seems to matter (though it doesn't seem like it should, in practice it seems to on occasion). For example, in setting up this system I initially had installed maybe a dozen ports via script, mostly smaller builds, but including advancemame. No trouble I noticed. Then when I tried to build gimp the build failed, and I didn't even note why... instead I uninstalled macports entirely and rebuilt it, and added gimp to my build script ahead of the other build installs, and it completed successfully, as well as the rest of the ports that I installed with that script.

I'm not sure I'm helping. You previously noted the port hasn't been maintained in awhile, and honestly I am not all that invested in it, but just trying to do my part. You said to report the bug, so I did.... But confirm your comment... if you say so. \o/

[mascguy (Christopher Nielsen)]

Thus far, I haven't looked at this port. But does mame still lack the video functionality/enhancements, that are present in advancemame...?

[jmroot (Joshua Root)]

It's currently failing on all platforms because of a missing dependency.

[jmroot (Joshua Root)]

In 2e07ebdd2dd0e5892079ade337e783af277116ec/macports-ports (master):

advancemame: add pkgconfig dep

See: #64077

[jmroot (Joshua Root)]

In bc6bfebc37b077ad6dac3ce9ae8575e07504d1e8/macports-ports (master):

advancemame: build fixes

Add missing pkgconfig dep, respect cxx_stdlib, and disable silent
build rules.

Closes: #64077