gnutls @3.6.16 +guile: does not build and install guile module gnutls

[mwette]

I tried several times to "port install gnutls +guile", separated by "port uninstall gnutls". The expected files did not appear in /opt/local/lib/guile/site/2.2/extensions nor in /opt/local/share/guile/site/2.2. Finally, I performed "port -k" and dug down to the build directory. I saw that the guile files were not created. I performed "cd guile; make" and the files were then built. I'm not sure about the install process so I stopped there.

macOS 11.6.2 Xcode 12.4

[mwette]

config.log from macports build dir

[mwette]

output of "make" in top-level dir, illustrating no guile build

[mwette]

output of "cd guile; make", illustrating that guile module Makefile was created

[reneeotten (Renee Otten)]

the Portfile says:

# there currently is a build issue with the guile variant
# the workaround is to first install w/o guile and then with +guile

so you could try that... whether this is something that can be solved I'll leave to Marius to comment on.

[mwette]

I did try that workaround., but it did not work for me.

(I have used that workaround in the past. IIRC, the issue was that the guile link phase was only looking in /opt/local/lib for libgnutls.so.)

[Schamschula (Marius Schamschula)]

I have to be honest: I haven't built the guile variant in several years - the last time might have been under the previous stable major version.

I'll look into it.

[ryandesign (Ryan Carsten Schmidt)]

The config.log says:

configure:68838: checking whether building Guile bindings
configure:68847: result: yes

configure:69114: checking for guile 2.2
configure:69117: $PKG_CONFIG --exists --print-errors "guile-$v"
configure:69120: $? = 0
configure:69137: found guile 2.2

configure:69685: checking whether GNU Guile is recent enough
configure:69698: /usr/bin/clang -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64 -D_THREAD_SAFE -I/opt/local/include/guile/2.2 -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64 -Wl,-no_weak_imports conftest.c -lintl  -L/opt/local/lib -lguile-2.2 -lgc >&5
conftest.c:543:1: error: implicit declaration of function 'scm_from_locale_string' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
scm_from_locale_string ("")
^
1 error generated.

So it's just the typical implicit declaration of function problem we see with a zillion other ports when using Xcode 12 or later. Fix the configure test to include whatever header declares scm_from_locale_string.

[mwette]

Guessing this:

--- configure.ac-orig	2022-01-25 07:55:31.000000000 -0800
+++ configure.ac	2022-01-25 07:55:55.000000000 -0800
@@ -1094,7 +1094,7 @@
       CFLAGS="$CFLAGS $GUILE_CFLAGS"
       LIBS="$LIBS $GUILE_LDFLAGS"
       AC_MSG_CHECKING([whether GNU Guile is recent enough])
-      AC_LINK_IFELSE([AC_LANG_PROGRAM([], [scm_from_locale_string ("")])],
+      AC_LINK_IFELSE([AC_LANG_PROGRAM([#include <libguile.h>], [scm_from_locale_string ("")])],
         [], [opt_guile_bindings=no])
       CFLAGS="$save_CFLAGS"
       LIBS="$save_LIBS"
r

EDIT: or <guile/2.2/libguile.h> but not sure how that gets in there
EDIT^2: I checked the gnutls repo: they have fixed it using #include <libguile.h>

[ryandesign (Ryan Carsten Schmidt)]

In 35edbee0b1af40d247ba890d562722af5843406c/macports-ports (master):

gnutls: Fix detection of guile in guile variant

Previously, with Xcode 12 or later, the guile variant would silently
build gnutls without guile support.

Closes: #64490

[cooljeanius (Eric Gallager)]

This caused #64628