rubberband @2.0.1: error: 'TARGET_OS_IPHONE' is not defined

[RobK88]

I am unable to upgrade the rubberband port on Lion. I will attach main.log

bash-3.2$ port outdated
The following installed ports are outdated:
rubberband                     2.0.0_2 < 2.0.1_0         
bash-3.2$ sudo port clean rubberband
--->  Cleaning rubberband
bash-3.2$ sudo port -v upgrade rubberband
--->  Computing dependencies for rubberband.
--->  Fetching distfiles for rubberband
--->  Verifying checksums for rubberband
--->  Checksumming rubberband-2.0.1.tar.bz2
--->  Extracting rubberband
--->  Extracting rubberband-2.0.1.tar.bz2
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work" && /usr/bin/bzip2 -dc '/opt/local/var/macports/distfiles/rubberband/rubberband-2.0.1.tar.bz2' | /usr/bin/gnutar --no-same-owner -xf - 
--->  Applying patches to rubberband
--->  Applying arch.patch
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/rubberband-2.0.1" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/audio/rubberband/files/arch.patch'
patching file meson.build
--->  Configuring rubberband
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/rubberband-2.0.1" && /opt/local/bin/meson --prefix=/opt/local -Dfft=vdsp -Dresampler=libsamplerate /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/rubberband-2.0.1 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/build 
The Meson build system
Version: 0.59.1
Source dir: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/rubberband-2.0.1
Build dir: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/build
Build type: native build
Project name: Rubber Band Library
Project version: 2.0.1
C compiler for the host machine: /opt/local/bin/clang-mp-12 (clang 12.0.1 "clang version 12.0.1")
C linker for the host machine: /opt/local/bin/clang-mp-12 ld64 274.2
C++ compiler for the host machine: /opt/local/bin/clang++-mp-12 (clang 12.0.1 "clang version 12.0.1")
C++ linker for the host machine: /opt/local/bin/clang++-mp-12 ld64 274.2
Host machine cpu family: x86_64
Host machine cpu: i386
Found pkg-config: /opt/local/bin/pkg-config (0.29.2)
Run-time dependency fftw3 found: YES 3.3.10
Run-time dependency samplerate found: YES 0.1.9
Run-time dependency sndfile found: YES 1.0.31
Found CMake: /opt/local/bin/cmake (3.22.1)
Run-time dependency vamp-sdk found: NO (tried pkgconfig, framework and cmake)
Run-time dependency threads found: YES
Has header "ladspa.h" : NO 
Has header "lv2.h" : NO 
Checking for function "sincos" : NO 
Has header "jni.h" : NO 
Program javac found: YES (/usr/bin/javac)
Program jar found: YES (/usr/bin/jar)
Message: For FFT: using vDSP
Message: For resampler: using libsamplerate
Has header "vamp-sdk.h" : NO 
Has header "vamp-sdk.h" : NO (cached)
Message: Will build Rubber Band Library static library
Message: Will build Rubber Band Library dynamic library
Message: Not building Java Native Interface: jni.h header not found
Message: Not building LADSPA plugin: ladspa.h header not found
Message: Not building LV2 plugin: lv2.h header not found
Message: Not building Vamp plugin: Vamp dependency not found
Message: Will build command-line utility
Build targets in project: 4

Rubber Band Library 2.0.1

  Directories
    prefix              : /opt/local
    bindir              : bin
    libdir              : lib
    datadir             : share

  Configuration
    FFT                 : vDSP
    Resampler           : libsamplerate
    Build type          : Release
    Target OS           : 10.7+
    Architecture        : x86_64

  Build targets
    Static library      : YES
                          Name: rubberband
    Dynamic library     : YES
                          Name: rubberband
    JNI library         : NO
    LADSPA plugin       : NO
    LV2 plugin          : NO
    Vamp plugin         : NO
    Command-line utility: YES
                          Name: rubberband

Found ninja-1.10.2 at /opt/local/bin/ninja
--->  Building rubberband
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/build" && /opt/local/bin/ninja -j4 -v 
[1/24] /opt/local/bin/clang++-mp-12 -Ilibrubberband_objlib.a.p -I. -I../rubberband-2.0.1 -I../rubberband-2.0.1/rubberband -I../rubberband-2.0.1/src -I/opt/local/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++14 -O3 -pipe -Os -mmacosx-version-min=10.7 -stdlib=libc++ -arch x86_64 -DHAVE_VDSP -DHAVE_LIBSAMPLERATE -DLACK_SINCOS -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DMALLOC_IS_ALIGNED -MD -MQ librubberband_objlib.a.p/src_rubberband-c.cpp.o -MF librubberband_objlib.a.p/src_rubberband-c.cpp.o.d -o librubberband_objlib.a.p/src_rubberband-c.cpp.o -c ../rubberband-2.0.1/src/rubberband-c.cpp
[2/24] /opt/local/bin/clang++-mp-12 -Ilibrubberband_objlib.a.p -I. -I../rubberband-2.0.1 -I../rubberband-2.0.1/rubberband -I../rubberband-2.0.1/src -I/opt/local/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++14 -O3 -pipe -Os -mmacosx-version-min=10.7 -stdlib=libc++ -arch x86_64 -DHAVE_VDSP -DHAVE_LIBSAMPLERATE -DLACK_SINCOS -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DMALLOC_IS_ALIGNED -MD -MQ librubberband_objlib.a.p/src_RubberBandStretcher.cpp.o -MF librubberband_objlib.a.p/src_RubberBandStretcher.cpp.o.d -o librubberband_objlib.a.p/src_RubberBandStretcher.cpp.o -c ../rubberband-2.0.1/src/RubberBandStretcher.cpp
FAILED: librubberband_objlib.a.p/src_RubberBandStretcher.cpp.o 
/opt/local/bin/clang++-mp-12 -Ilibrubberband_objlib.a.p -I. -I../rubberband-2.0.1 -I../rubberband-2.0.1/rubberband -I../rubberband-2.0.1/src -I/opt/local/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++14 -O3 -pipe -Os -mmacosx-version-min=10.7 -stdlib=libc++ -arch x86_64 -DHAVE_VDSP -DHAVE_LIBSAMPLERATE -DLACK_SINCOS -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DMALLOC_IS_ALIGNED -MD -MQ librubberband_objlib.a.p/src_RubberBandStretcher.cpp.o -MF librubberband_objlib.a.p/src_RubberBandStretcher.cpp.o.d -o librubberband_objlib.a.p/src_RubberBandStretcher.cpp.o -c ../rubberband-2.0.1/src/RubberBandStretcher.cpp
In file included from ../rubberband-2.0.1/src/RubberBandStretcher.cpp:24:
In file included from ../rubberband-2.0.1/src/StretcherImpl.h:29:
In file included from ../rubberband-2.0.1/src/dsp/Window.h:32:
../rubberband-2.0.1/src/dsp/../system/VectorOps.h:733:5: error: 'TARGET_OS_IPHONE' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
#if TARGET_OS_IPHONE
    ^
1 error generated.
[3/24] /opt/local/bin/clang++-mp-12 -Ilibrubberband_objlib.a.p -I. -I../rubberband-2.0.1 -I../rubberband-2.0.1/rubberband -I../rubberband-2.0.1/src -I/opt/local/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++14 -O3 -pipe -Os -mmacosx-version-min=10.7 -stdlib=libc++ -arch x86_64 -DHAVE_VDSP -DHAVE_LIBSAMPLERATE -DLACK_SINCOS -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DMALLOC_IS_ALIGNED -MD -MQ librubberband_objlib.a.p/src_base_Profiler.cpp.o -MF librubberband_objlib.a.p/src_base_Profiler.cpp.o.d -o librubberband_objlib.a.p/src_base_Profiler.cpp.o -c ../rubberband-2.0.1/src/base/Profiler.cpp
[4/24] /opt/local/bin/clang++-mp-12 -Ilibrubberband_objlib.a.p -I. -I../rubberband-2.0.1 -I../rubberband-2.0.1/rubberband -I../rubberband-2.0.1/src -I/opt/local/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++14 -O3 -pipe -Os -mmacosx-version-min=10.7 -stdlib=libc++ -arch x86_64 -DHAVE_VDSP -DHAVE_LIBSAMPLERATE -DLACK_SINCOS -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DMALLOC_IS_ALIGNED -MD -MQ librubberband_objlib.a.p/src_StretcherProcess.cpp.o -MF librubberband_objlib.a.p/src_StretcherProcess.cpp.o.d -o librubberband_objlib.a.p/src_StretcherProcess.cpp.o -c ../rubberband-2.0.1/src/StretcherProcess.cpp
FAILED: librubberband_objlib.a.p/src_StretcherProcess.cpp.o 
/opt/local/bin/clang++-mp-12 -Ilibrubberband_objlib.a.p -I. -I../rubberband-2.0.1 -I../rubberband-2.0.1/rubberband -I../rubberband-2.0.1/src -I/opt/local/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++14 -O3 -pipe -Os -mmacosx-version-min=10.7 -stdlib=libc++ -arch x86_64 -DHAVE_VDSP -DHAVE_LIBSAMPLERATE -DLACK_SINCOS -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DMALLOC_IS_ALIGNED -MD -MQ librubberband_objlib.a.p/src_StretcherProcess.cpp.o -MF librubberband_objlib.a.p/src_StretcherProcess.cpp.o.d -o librubberband_objlib.a.p/src_StretcherProcess.cpp.o -c ../rubberband-2.0.1/src/StretcherProcess.cpp
In file included from ../rubberband-2.0.1/src/StretcherProcess.cpp:24:
In file included from ../rubberband-2.0.1/src/StretcherImpl.h:29:
In file included from ../rubberband-2.0.1/src/dsp/Window.h:32:
../rubberband-2.0.1/src/dsp/../system/VectorOps.h:733:5: error: 'TARGET_OS_IPHONE' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
#if TARGET_OS_IPHONE
    ^
1 error generated.
[5/24] /opt/local/bin/clang++-mp-12 -Ilibrubberband_objlib.a.p -I. -I../rubberband-2.0.1 -I../rubberband-2.0.1/rubberband -I../rubberband-2.0.1/src -I/opt/local/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++14 -O3 -pipe -Os -mmacosx-version-min=10.7 -stdlib=libc++ -arch x86_64 -DHAVE_VDSP -DHAVE_LIBSAMPLERATE -DLACK_SINCOS -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DMALLOC_IS_ALIGNED -MD -MQ librubberband_objlib.a.p/src_StretchCalculator.cpp.o -MF librubberband_objlib.a.p/src_StretchCalculator.cpp.o.d -o librubberband_objlib.a.p/src_StretchCalculator.cpp.o -c ../rubberband-2.0.1/src/StretchCalculator.cpp
ninja: build stopped: subcommand failed.
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/work/build" && /opt/local/bin/ninja -j4 -v 
Exit code: 1
Error: Failed to build rubberband: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_rubberband/rubberband/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.

[RobK88]

main.log

[ryandesign (Ryan Carsten Schmidt)]

Oh joy. Well this is because MacPorts changed to using a newer fallback compiler by default, and newer clang treats this condition as an error.

It sounds like one is supposed to #include <TargetConditionals.h> before checking TARGET_OS_ constants. I'll see what I can do.

[ryandesign (Ryan Carsten Schmidt)]

In c5ba28c70240e566cf5c61335f548979dbb125bf/macports-ports (master):

rubberband: Fix build on <= 10.8 with Clang 12

Closes: #64506