p5.30-xml-parser fails to build for ppc. UPD: Solution found, open a pull request?

[barracuda156]

:info:build Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-xml-parser/p5.30-xml-parser/work/XML-Parser-2.46" && /usr/bin/make -j4 -w all 
:debug:build system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-xml-parser/p5.30-xml-parser/work/XML-Parser-2.46" && /usr/bin/make -j4 -w all 
:info:build make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-xml-parser/p5.30-xml-parser/work/XML-Parser-2.46'
:info:build make: *** No rule to make target `all'.  Stop.
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-xml-parser/p5.30-xml-parser/work/XML-Parser-2.46'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-xml-parser/p5.30-xml-parser/work/XML-Parser-2.46" && /usr/bin/make -j4 -w all 
:info:build Exit code: 2
:error:build Failed to build p5.30-xml-parser: command execution failed
:debug:build Error code: CHILDSTATUS 51678 2
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "system {*}$notty {*}$callback {*}$nice $fullcmdstring"
:debug:build     invoked from within
:debug:build "command_exec -callback portprogress::target_progress_callback build"
:debug:build     (procedure "portbuild::build_main" line 8)
:debug:build     invoked from within
:debug:build "$procedure $targetname"
:error:build See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-xml-parser/p5.30-xml-parser/main.log for details.

[ryandesign (Ryan Carsten Schmidt)]

The reason seems to be that it can't find expat at configure time.

:info:configure Expat must be installed prior to building XML::Parser and I can't find
:info:configure it in the standard library directories. Install 'expat-devel' (or
:info:configure 'libexpat1-dev') package with your OS package manager. See 'README'.
:info:configure Or you can download expat from:
:info:configure http://sourceforge.net/projects/expat/
:info:configure If expat is installed, but in a non-standard directory, then use the
:info:configure following options to Makefile.PL:
:info:configure     EXPATLIBPATH=...  To set the directory in which to find libexpat
:info:configure     EXPATINCPATH=...  To set the directory in which to find expat.h
:info:configure For example:
:info:configure     perl Makefile.PL EXPATLIBPATH=/home/me/lib EXPATINCPATH=/home/me/include

If a config.log was created in the source directory, it may tell us why it couldn't find expat; please attach it.

Two apparently unsuccessful attempts were already made to fix this:

• [ed3f3a708bc474391c028753f67b6a066e9eee3d/macports-ports]
• [10ff9d6f9e081d9cfe50385c0a69a76f6d2498d2/macports-ports]

If you can work out the correct fix, please submit a pull request.

[barracuda156]

Replying to ryandesign:

Two apparently unsuccessful attempts were already made to fix this:

• [ed3f3a708bc474391c028753f67b6a066e9eee3d/macports-ports]
• [10ff9d6f9e081d9cfe50385c0a69a76f6d2498d2/macports-ports]

If you can work out the correct fix, please submit a pull request.

I did. This works:

if {${perl5.major} != ""} {
    depends_lib-append \
                    port:expat \
                    port:p${perl5.major}-libwww-perl
    configure.args-append \
                    LD_LIBRARY_PATH=/opt/local/lib
    configure.post_args-append \
                    EXPATLIBPATH=/opt/local/lib \
                    EXPATINCPATH=/opt/local/include
}

Can I create a pull request on Github for this?

Sergey-Fedorovs-Mac-mini:~ svacchanda$ port -v installed | grep xml-parser
  p5.28-xml-parser @2.460.0_0 (active) requested_variants='' platform='darwin 10' archs='ppc' date='2022-02-06T17:17:26+0800'
  p5.30-xml-parser @2.460.0_0 (active) requested_variants='' platform='darwin 10' archs='ppc' date='2022-02-06T17:12:15+0800'
  p5.30-xml-parser-lite @0.722.0_0 (active) requested_variants='' platform='darwin 10' archs='noarch' date='2022-01-28T07:39:50+0800'
  p5.34-xml-parser @2.460.0_0 (active) requested_variants='' platform='darwin 10' archs='ppc' date='2022-02-06T17:14:38+0800'
  p5.34-xml-parser-lite @0.722.0_0 (active) requested_variants='' platform='darwin 10' archs='noarch' date='2022-01-28T07:40:21+0800'

[jmroot (Joshua Root)]

In ed49a07e78f902c75c0a32da2de20a152eea4198/macports-ports (master):

p5-xml-parser: fix configure check

Closes: #64543