openal-soft fails to compile pre 10.10 with newer compilers (llvm-11+)

[Gcenx]

The same story as with other Ports this time it’s TARGET_OS_IOS & TARGET_OS_TV

/alc/backends/coreaudio.cpp line 48

[kencu (Ken)]

Most are in legacysupport now.

Just add that and you're usually good to go, unless there is some special case like re2.

Throw in any others needed to there (if you find any).

Nothing to do with the compiler, I think.

[Gcenx]

Replying to kencu:

Most are in legacysupport now.

Just add that and you're usually good to go, unless there is some special case like re2.

Throw in any others needed to there (if you find any).

Nothing to do with the compiler, I think.

Yeah I’d seen them mapped in LegacySupport already but that’s honestly overkill as the checks are only in that one file.

I’ve only noticed this one mostly due to regression testing on 10.9 (what fun)

From llvm-11 and later undefined targets are an error causing build failures, so I guess you could simply blame the upstream due to using newer references and no fallback but also the compiler for only now complaining about this.

[kencu (Ken)]

I'm sorry to see the legacysupport get to the point of being considered overkill... I always meant it to be transparently lightweight, and the first goto for stuff like this.

I didn't try it yet though, so perhaps it won't fix it anyway.

Best of luck!

[Gcenx]

Replying to kencu:

I'm sorry to see the legacysupport get to the point of being considered overkill... I always meant it to be transparently lightweight, and the first goto for stuff like this.

I didn't try it yet though, so perhaps it won't fix it anyway.

Best of luck!

It’s not that LegacySupport isn't good (it’s been very useful), if it were possible to only use the remapped headers (Apple loves to change function names….) that would avoid a lot of issues.

It had built with LegacySupport but I didn’t test it as I’ve had issues with legacysuport when not set to static. As the only issue was the mentioned missing definitions I’d silenced the error. A quick patch to that one file to remap the new>old definitions would be more upstream acceptable but no idea if they even be interested.

Thanks Ken

[Dean M Greer <38226388+Gcenx@…>]

In e396e1d96db5453fa31b9ef8a64282d7a1cad5a1/macports-ports (master):

openal-soft: Use legacysupport

Closes #64548