DiffPDF @2.1.3: error: expected ‘;’ before ‘override’

[barracuda156]

In file included from /opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-qt4.h:37,
                 from generic.hpp:15,
                 from textitem.hpp:15,
                 from textitem.cpp:13:
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-annotation.h:460: error: expected ‘;’ before ‘override’
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-annotation.h:546: error: expected ‘;’ before ‘override’
In file included from /opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-qt4.h:38,
                 from generic.hpp:15,
                 from textitem.hpp:15,
                 from textitem.cpp:13:
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-link.h:271: error: expected ‘;’ before ‘override’
In file included from /opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-qt4.h:37,
                 from generic.hpp:15,
                 from optionsform.cpp:13:
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-annotation.h:460: error: expected ‘;’ before ‘override’
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-annotation.h:546: error: expected ‘;’ before ‘override’
In file included from /opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-qt4.h:38,
                 from generic.hpp:15,
                 from optionsform.cpp:13:
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-link.h:271: error: expected ‘;’ before ‘override’
In file included from /opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-qt4.h:37,
                 from generic.hpp:15,
                 from mainwindow.cpp:13:
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-annotation.h:460: error: expected ‘;’ before ‘override’
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-annotation.h:546: error: expected ‘;’ before ‘override’
In file included from /opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-qt4.h:38,
                 from generic.hpp:15,
                 from mainwindow.cpp:13:
/opt/local/libexec/poppler-qt4-mac/include/poppler/qt4/poppler-link.h:271: error: expected ‘;’ before ‘override’
make: *** [textitem.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [optionsform.o] Error 1
make: *** [mainwindow.o] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_DiffPDF/DiffPDF/work/diffpdf-2.1.3'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_DiffPDF/DiffPDF/work/diffpdf-2.1.3" && /usr/bin/make -j4 -w all 
Exit code: 2
Error: Failed to build DiffPDF: command execution failed

[evanmiller (Evan Miller)]

It looks like poppler-qt4 expects C++11. Adding compiler.cxx_standard 2011 will get past this error, but I see some other errors when QT4 actually tries to bundle the application.

[barracuda156]

Replying to evanmiller:

It looks like poppler-qt4 expects C++11. Adding compiler.cxx_standard 2011 will get past this error, but I see some other errors when QT4 actually tries to bundle the application.

I tried that, and while I got an error in verbose:

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_DiffPDF/DiffPDF/work/compwrap/cxx/opt/local/bin/g++-mp-7 -I/opt/local/include -L/opt/local/lib -Wl,-headerpad_max_install_names -o diffpdf.app/Contents/MacOS/diffpdf mainwindow.o textitem.o aboutform.o optionsform.o helpform.o saveform.o generic.o sequence_matcher.o main.o lineedit.o label.o moc_mainwindow.o moc_aboutform.o moc_optionsform.o moc_helpform.o moc_saveform.o moc_lineedit.o moc_label.o qrc_resources.o   -F/opt/local/libexec/qt4/Library/Frameworks -F/opt/local/libexec/qt4/lib  -L/opt/local/libexec/poppler-qt4-mac/lib -lpoppler-qt4 -F/opt/local/libexec/qt4/Library/Frameworks -F/opt/local/libexec/qt4/lib -L/opt/local/libexec/qt4/lib -framework QtGui -F/opt/local/Library/Frameworks -framework QtCore 
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_DiffPDF/DiffPDF/work/diffpdf-2.1.3'
ERROR: no file at "/opt/local/lib/lib/libstdc++.6.dylib" 
ERROR: no file at "/opt/local/lib/lib/libgcc_s.1.dylib"

It has nevertheless finished the build and installed:

36-47:~ svacchanda$ port -v installed DiffPDF
The following ports are currently installed:
  DiffPDF @2.1.3_0 (active) requested_variants='' platform='darwin 9' archs='ppc' date='2022-02-16T21:30:26+0800'

[evanmiller (Evan Miller)]

Does the .app bundle actually open and work? It appears that bundling fails but the build "succeeds".

[barracuda156]

Replying to evanmiller:

Does the .app bundle actually open and work? It appears that bundling fails but the build "succeeds".

Yes, it actually works.

[evanmiller (Evan Miller)]

Replying to barracuda156:

Replying to evanmiller:

Does the .app bundle actually open and work? It appears that bundling fails but the build "succeeds".

Yes, it actually works.

OK, good to know. I might be having issues locally due to a case-sensitive file system.

[ryandesign (Ryan Carsten Schmidt)]

I'll commit the fix in a moment.

Evan, if you're still having trouble using DiffPDF on your case-sensitive system, please file a new ticket since it sounds like an unrelated issue.

[ryandesign (Ryan Carsten Schmidt)]

In eb1fd73283680cd6cee808ff9c3b7549da887a2d/macports-ports (master):

DiffPDF: Use C++11

Closes: #64644