Opened 2 years ago

Closed 2 years ago

#64849 closed defect (fixed)

aubio: backport fftw3-setup patch from py-aubio

Reported by: aeiouaeiouaeiouaeiouaeiouaeiou Owned by: aeiouaeiouaeiouaeiouaeiouaeiou
Priority: Normal Milestone:
Component: ports Version: 2.7.2
Keywords: Cc:
Port: aubio

Description

On my 10.8 system I tried to use this patch: https://github.com/macports/macports-ports/blob/70fcb61651cc76ad22fb8c0bca23cdad3eccc1f0/python/py-aubio/files/fftw3-setup.py.patch

For some reason the compiler keeps looking for the vDSP_DCT function in the files:

[ 53/231] Compiling src/io/source_sndfile.c
19:43:00 runner ['/usr/bin/clang', '-g', '-Wall', '-Wextra', '-O2', '-pipe', '-Os', '-arch', 'x86_64', '-fPIC', '-Isrc', '-I../src', '-I../../../../../../../../include/opus', '-DHAVE_CONFIG_H=1', '-DAUBIO_PREFIX="/opt/local"', '-DPACKAGE="aubio"', '../src/io/source_sndfile.c', '-c', '-o/opt/local/var/macports/build/_Users_user_macports-ports_audio_aubio/aubio/work/aubio-0.4.9/build/src/io/source_sndfile.c.1.o', '-I/opt/local/include']
../src/spectral/dct_accelerate.c:51:14: warning: implicit declaration of function 'vDSP_DCT_CreateSetup' is invalid in C99 [-Wimplicit-function-declaration]
  s->setup = vDSP_DCT_CreateSetup(NULL, (vDSP_Length)size, vDSP_DCT_II);
             ^
../src/spectral/dct_accelerate.c:51:60: error: use of undeclared identifier 'vDSP_DCT_II'
  s->setup = vDSP_DCT_CreateSetup(NULL, (vDSP_Length)size, vDSP_DCT_II);
                                                           ^
../src/spectral/dct_accelerate.c:52:63: error: use of undeclared identifier 'vDSP_DCT_III'; did you mean 'vDSP_DFT_zop'?
  s->setupInv = vDSP_DCT_CreateSetup(NULL, (vDSP_Length)size, vDSP_DCT_III);
                                                              ^~~~~~~~~~~~
                                                              vDSP_DFT_zop
/System/Library/Frameworks/vecLib.framework/Headers/vDSP.h:8029:6: note: 'vDSP_DFT_zop' declared here
void vDSP_DFT_zop(
     ^
../src/spectral/dct_accelerate.c:52:15: warning: incompatible integer to pointer conversion assigning to 'vDSP_DFT_Setup' (aka 'struct vDSP_DFT_SetupStruct *') from 'int' [-Wint-conversion]
  s->setupInv = vDSP_DCT_CreateSetup(NULL, (vDSP_Length)size, vDSP_DCT_III);
              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/spectral/dct_accelerate.c:74:3: warning: implicit declaration of function 'vDSP_DCT_Execute' is invalid in C99 [-Wimplicit-function-declaration]
  vDSP_DCT_Execute(s->setup, (const float *)input->data, (float *)output->data);
  ^
3 warnings and 2 errors generated.

Change History (3)

comment:1 Changed 2 years ago by aeiouaeiouaeiouaeiouaeiouaeiou

Cc: aeiouaeiouaeiouaeiouaeiouaeiou added

comment:2 Changed 2 years ago by aeiouaeiouaeiouaeiouaeiouaeiou

Cc: aeiouaeiouaeiouaeiouaeiouaeiou removed
Summary: backport fftw3-setup.py.patch from py-aubioaubio: backport fftw3-setup patch from py-aubio
Type: enhancementdefect
Version: 2.7.2

comment:3 Changed 2 years ago by aeiouaeiouaeiouaeiouaeiouaeiou

Owner: set to aeiouaeiouaeiouaeiouaeiouaeiou
Resolution: fixed
Status: newclosed

In 816ac4efa881ebec76a1320d27306b73c19c6a9b/macports-ports (master):

aubio: fix build on macOS 10.8 Mountain Lion and older

Closes: #64849

Note: See TracTickets for help on using tickets.