Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#65262 closed defect (fixed)

glib2-upstream: build error on 10.7; undeclared identifier LOCAL_PEERPID

Reported by: mascguy (Christopher Nielsen) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version: 2.7.2
Keywords: Cc:
Port: glib2-upstream

Description

Starting with version 2.72.1, support for the macOS local peerpid was added. Unfortunately it causes a compilation issue on 10.7:

[707/1188] /opt/local/bin/clang-mp-3.7 -Igio/libgio-2.0.0.dylib.p -Igio -I../glib-2.73.0/gio -I. -I../glib-2.73.0 -Iglib -I../glib-2.73.0/glib -Igobject -I../glib-2.73.0/gobject -Igmodule -I../glib-2.73.0/gmodule -I/opt/local/include -fcolor-diagnostics -std=gnu99 -O2 -g -D_GNU_SOURCE -fno-strict-aliasing -DG_ENABLE_DEBUG -Wimplicit-fallthrough -Wunused -Wno-unused-parameter -Wno-pedantic -Wno-format-zero-length -Wno-variadic-macros -Werror=format=2 -Werror=init-self -Werror=missing-include-dirs -Werror=pointer-arith -Wstrict-prototypes -Wno-bad-function-cast -Wno-declaration-after-statement -Werror=implicit-function-declaration -Werror=missing-prototypes -pipe -Os -fstrict-aliasing -Wno-deprecated-declarations -arch x86_64 '-DG_LOG_DOMAIN="GLib-GIO"' -DGIO_COMPILATION '-DGIO_MODULE_DIR="/opt/local/lib/gio/modules"' '-DLOCALSTATEDIR="/opt/local/var"' -fvisibility=hidden -MD -MQ gio/libgio-2.0.0.dylib.p/gsocket.c.o -MF gio/libgio-2.0.0.dylib.p/gsocket.c.o.d -o gio/libgio-2.0.0.dylib.p/gsocket.c.o -c ../glib-2.73.0/gio/gsocket.c

FAILED: gio/libgio-2.0.0.dylib.p/gsocket.c.o
../glib-2.73.0/gio/gsocket.c:6082:29: error: use of undeclared identifier 'LOCAL_PEERPID'
                            LOCAL_PEERPID,
                            ^
1 error generated.

Discussion started with upstream, in hopes that this can be promptly fixed:

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2362#note_1468346

Change History (5)

comment:1 Changed 2 years ago by Christopher Nielsen <mascguy@…>

In 19afd2a36c34b0c8fab901836f6cb086969ff4f2/macports-ports (master):

glib2-upstream: patch for peerpid build error
See: #65262

comment:2 Changed 2 years ago by mascguy (Christopher Nielsen)

Summary: glib2-upstream: build error on 10.7; undeclared identified LOCAL_PEERPIDglib2-upstream: build error on 10.7; undeclared identifier LOCAL_PEERPID

comment:3 Changed 2 years ago by mascguy (Christopher Nielsen)

Per discussion with upstream, merge request has been created:

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2707

comment:4 Changed 2 years ago by mascguy (Christopher Nielsen)

Resolution: fixed
Status: assignedclosed

Upstream has approved and merged changes. Closing.

comment:5 Changed 2 years ago by mascguy (Christopher Nielsen)

One final note: In addition to being included in 2.73.x, this change will also be backported to 2.72.x:

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2709

Note: See TracTickets for help on using tickets.