hdfeos5 @1.16_7: configure script thinks hdf5 was linked without SZIP, when actually it was

[cooljeanius (Eric Gallager)]

checking for fc2Fortran macro... not defined
checking for /opt/local/include/szlib.h... yes
checking szlib.h usability... yes
checking szlib.h presence... yes
checking for szlib.h... yes
checking for SZ_BufftoBuffCompress in -lsz... yes
checking for gawk... (cached) gawk
checking for h5cc... /opt/local/bin/h5cc
gawk: cmd. line:1: warning: regexp escape sequence `\"' is not a known regexp operator
checking for szlib encoder... shared szlib doesn't work. disabling szip.
checking hdf5.h usability... yes
checking hdf5.h presence... yes
checking for hdf5.h... yes
checking for H5Fcreate in -lhdf5... yes
checking if HDF5 threadsafe mode is enabled... no
checking for hdf5 szip decoding filter... no
checking for hdf5 szip encoding filter... no
configure: error: HDF5 was linked without SZIP, but --with-szlib was given
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_hdfeos5/hdfeos5/work/hdfeos5" && ./configure --prefix=/opt/local --prefix=/opt/local/lib/hdfeos5 --enable-shared --with-zlib=/opt/local --disable-dependency-tracking --with-szlib=/opt/local 
Exit code: 1
Error: Failed to configure hdfeos5: consult /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_hdfeos5/hdfeos5/work/hdfeos5/config.log
Error: Failed to configure hdfeos5: configure failure: command execution failed
DEBUG: Error code: NONE
DEBUG: Backtrace: configure failure: command execution failed
    while executing
"$procedure $targetname"
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_hdfeos5/hdfeos5/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.

However:

$ port installed hdf5
The following ports are currently installed:
  hdf5 @1.12.2_0+cxx+fortran+gfortran+hl+szip (active)

Checking config.log shows that it turns out to be an instance of the -Werror=implicit-function-declaration issue:

configure:22754: checking for hdf5 szip encoding filter
configure:22796: /opt/local/bin/h5cc -o conftest -pipe -Os -DH5_USE_16_API -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -I/opt/local/include -I/opt/local/include -L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -L/opt/local/lib -L/opt/local/lib conftest.c -lhdf5_hl -lhdf5 -lsz -lz -lm  >&5
clang: warning: -Wl,-headerpad_max_install_names: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-L/opt/local/lib' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-L/opt/local/lib' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-L/opt/local/lib' [-Wunused-command-line-argument]
conftest.c:39:21: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
              if (ret < 0) exit(1);
                           ^
conftest.c:39:21: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
1 error generated.
configure:22799: $? = 1
configure: program exited with status 1
configure: failed program was:
| /* confdefs.h.  */
| #define PACKAGE_NAME "hdf-eos5"
| #define PACKAGE_TARNAME "hdf-eos5"
| #define PACKAGE_VERSION "1.8"
| #define PACKAGE_STRING "hdf-eos5 1.8"
| #define PACKAGE_BUGREPORT "null@bogus.email"
| #define PACKAGE "hdf-eos5"
| #define VERSION "1.8"
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define HAVE_DLFCN_H 1
| #define HAVE_LIBM 1
| #define HAVE_ZLIB_H 1
| #define HAVE_LIBZ 1
| #define HAVE_SZLIB_H 1
| #define HAVE_LIBSZ 1
| #define HAVE_HDF5_H 1
| #define HAVE_LIBHDF5 1
| /* end confdefs.h.  */
| 
|       #include <H5Ipublic.h>
|       #include <H5Zpublic.h>
| 
|       int main(int argc, char **argv)
|       {
|               herr_t ret;
|               unsigned int flags = 0;
|               int encoder = 0;
| 
|               ret = H5Zget_filter_info(H5Z_FILTER_SZIP, &flags);
| 	      if (ret < 0) exit(1);
|               encoder = flags & H5Z_FILTER_CONFIG_ENCODE_ENABLED;
|               if (encoder) exit(0);
|               else exit(1);
|       }
| 
configure:22835: result: no
configure:22841: error: HDF5 was linked without SZIP, but --with-szlib was given

[ryandesign (Ryan Carsten Schmidt)]

In 6732bdf1887d4dd93ca0b0241974a8f3e7fa0b8f/macports-ports (master):

hdfeos5: Fix implicit func decls in szip variant

Closes: #65288