#65480 closed defect (fixed)
glib2-devel @2.68.4: build fails for 10.6; undeclared identifier F_DUPFD_CLOEXEC
| Reported by: | mascguy (Christopher Nielsen) | Owned by: | mascguy (Christopher Nielsen) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.7.2 |
| Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt) | |
| Port: | glib2-devel |
Description (last modified by mascguy (Christopher Nielsen))
Based on a quick review of upstream's changelog, this was fixed at some point in the past. And perhaps we have a patch in the Git history, for an older glib2 release.
Need to do more digging, but hopefully this shouldn't be a big deal to fix.
Details:
:info:build ../glib-2.68.4/glib/tests/spawn-singlethread.c:454:35: error: use of undeclared identifier 'F_DUPFD_CLOEXEC' :info:build int source = fcntl (tmp_fd, F_DUPFD_CLOEXEC, 3);
Change History (7)
comment:1 Changed 22 months ago by mascguy (Christopher Nielsen)
| Description: | modified (diff) |
|---|
comment:2 follow-up: 3 Changed 22 months ago by ryandesign (Ryan Carsten Schmidt)
comment:3 Changed 22 months ago by mascguy (Christopher Nielsen)
Replying to ryandesign:
It was fixed at one point in 2.39.1.
https://github.com/GNOME/glib/commit/6bb9d17e40deb230ab14f369304b8feca02230c0
Yes indeed, and the commit tags indicate that it's included in every subsequent release.
Still digging...
comment:4 Changed 22 months ago by mascguy (Christopher Nielsen)
Interestingly enough, while upstream's fix is included in several source files - things have evolved since the commit for 2.39.1, as you'd expect - it's still missing from glib/tests/spawn-singlethread.c.
Assuming I'm not missing something, I'll fix, and provide a report/patch to upstream.
comment:5 follow-up: 7 Changed 22 months ago by mascguy (Christopher Nielsen)
Issue reported to upstream; patch will be provided once validated.
comment:6 Changed 22 months ago by Christopher Nielsen <mascguy@…>
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:7 Changed 22 months ago by mascguy (Christopher Nielsen)
Replying to mascguy:
Issue reported to upstream; patch will be provided once validated.
Closed upstream issue, as this is limited to 2.68.x.
It was fixed at one point in 2.39.1.
https://github.com/GNOME/glib/commit/6bb9d17e40deb230ab14f369304b8feca02230c0