librsvg fails to compile for multiple issues on Leopard

[rmottola (Riccardo)]

First, on 10.5 it uses the default apple gcc 4.2 compile

Rsvg-2.0-custom.vala:35.3-35.12: warning: [Deprecated] is deprecated. Use [Version (deprecated = true, deprecated_since = "", replacement = "")]
   35 | 	[Deprecated (since = "2.36")]
      | 	 ^~~~~~~~~~                  
GdkPixbuf-2.0.gir:6286.55-6286.55: error: The symbol `GModule' could not be found
 6286 |         <type name="GModule.Module" c:type="GModule*"/>
      |                                                       ^
Generation failed: 1 error(s), 13 warning(s)
make[2]: *** [librsvg-2.0.vapi] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_librsvg/librsvg/work/librsvg-2.40.20'

This looks similar to bug ​https://trac.macports.org/ticket/65407

I force the use of GCC 7 and get this error then:

./libtool: eval: line 1719: syntax error near unexpected token `|'

[rmottola (Riccardo)]

For the invalid nm argument, I followed a classic trick by @kencu

if {${os.platform} eq "darwin" && ${os.major} < 10} {
    depends_build-append port:cctools
    configure.env-append NM=${prefix}/bin/nm
    configure.args-append lt_cv_path_NM=${prefix}/bin/nm
}

as cited e.g. in ​https://trac.macports.org/ticket/60282

[rmottola (Riccardo)]

unfortunately using new nm and new gcc, returns at the end the same issue

GdkPixbuf-2.0.gir:6286.55-6286.55: error: The symbol `GModule' could not be found
 6286 |         <type name="GModule.Module" c:type="GModule*"/>

so perhaps except using nm to allow newer compilers (which seem not mandatory, but useful to have) this is a duplicate of ​https://trac.macports.org/ticket/65407

[rmottola (Riccardo)]

I think now there are also some patches that need updating:

--->  Applying patch-librsvg-makefile-in-vapi-deps.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_librsvg/librsvg/work/librsvg-2.40.21" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/librsvg/files/patch-librsvg-makefile-in-vapi-deps.diff'
patching file Makefile.in
Hunk #1 succeeded at 805 (offset 29 lines).
--->  Applying patch-disable-viewer-pre-cargo.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_librsvg/librsvg/work/librsvg-2.40.21" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/librsvg/files/patch-disable-viewer-pre-cargo.diff'
patching file Makefile.in
Hunk #2 FAILED at 254.
1 out of 2 hunks FAILED -- saving rejects to file Makefile.in.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_librsvg/librsvg/work/librsvg-2.40.21" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/librsvg/files/patch-disable-viewer-pre-cargo.diff'
Exit code: 1

[mascguy (Christopher Nielsen)]

Replying to rmottola:

I think now there are also some patches that need updating

I'm not surprised, as the PR was merged before I had a chance to verify on 10.5.

I'll take a look in a day or two.

[mascguy (Christopher Nielsen)]

Has duplicate issue:68430

[Christopher Nielsen <mascguy@…>]

In 46d34674332d01e9e6629625a3cd6ec71a0ff1be/macports-ports (master):

librsvg{,-devel}: fix patch for fallback version

See: #66344

[mascguy (Christopher Nielsen)]

Riccardo, how do things look, now that the patches have been fixed?