Gegl fails after libraw update

[pietvo (Pieter van Oostrum)]

After a recent libraw update gegl no longer compiles. (​https://github.com/macports/macports-ports/commit/144bf8fbcc5417ec1d8950ff2e232d6eec8a507c#commitcomment-95694848)

[pietvo (Pieter van Oostrum)]

log file

[Gandoon (Erik Hedlund)]

Also ImageMagick is affected by this problem. I just keep the previous versions active for the time being.

[Lev-GitHub]

I've encountered a similar situation without the "quartz" option.

[Lev-GitHub]

Gegl error log file

[lukaso (Lukas Oberhuber)]

Here is the upstream issue: ​https://gitlab.gnome.org/GNOME/gegl/-/issues/315

Could version 0.20.2 be given it's own port?

[mascguy (Christopher Nielsen)]

Replying to lukaso:

Here is the upstream issue: ​https://gitlab.gnome.org/GNOME/gegl/-/issues/315

Could version 0.20.2 be given it's own port?

That's certainly an option, depending on whether any other ports are broken.

Is the API change simple/isolated enough, that we could easily patch gegl for now? Your thoughts Lukas?

[ryandesign (Ryan Carsten Schmidt)]

Has duplicates #66668 and #66673.

[cjones051073 (Chris Jones)]

Replying to mascguy:

Replying to lukaso:

Here is the upstream issue: ​https://gitlab.gnome.org/GNOME/gegl/-/issues/315

Could version 0.20.2 be given it's own port?

That's certainly an option, depending on whether any other ports are broken.

Is the API change simple/isolated enough, that we could easily patch gegl for now? Your thoughts Lukas?

Adding multiple versioned ports should only be done in specific circumstances, and this does not seem like one to me. By far the preferable solution is to patch the ports that need it to work with the new API (which upstream for those ports should anyway do).

[pietvo (Pieter van Oostrum)]

This patch is sufficient to get it compiled:

--- operations/external/raw-load.c.~1~
+++ operations/external/raw-load.c
@@ -114,7 +114,7 @@
         g_warning ("raw-load: Error Initializing raw library");
       else
         {
-          p->LibRaw->params.shot_select = o->image_num;
+          p->LibRaw->rawparams.shot_select = o->image_num;
     
           p->LibRaw->params.aber[0] = 1.0;
           p->LibRaw->params.aber[2] = 1.0;

I can submit a PR.

[michaelld (Michael Dickens)]

PR: ​https://github.com/macports/macports-ports/pull/17294

[josephsacco]

Applying the patch allowed gel to build.

I tried running some of the examples that come with the package, but I cannot get them to work. For example:

cavandish:examples jsacco$ ./hello-world

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.227: cannot register existing type 'GeglModule'

(hello-world:91432): GLib-CRITICAL **: 15:33:58.228: g_once_init_leave: assertion 'result != 0' failed

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.228: invalid cast from 'GeglModule' to '<invalid>'

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.281: Two different plugins tried to register 'GeglOpseamless-clone_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.281: Two different plugins tried to register 'GeglOppixbuf_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpff-load_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpcache_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpcast-format_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpcast-space_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpclone_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpconvert-format_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpconvert-space_c'.

(hello-world:91432): GLib-GObject-WARNING **: 15:33:58.283: Two different plugins tried to register 'GeglOpcrop_c'.

Was something supposed to appear soon my screen?

This may very well be "pilot error" on my part, but... Someone who actually understands this code might want to take a look.

-Joseph

[michaelld (Michael Dickens)]

In fa5f5b551c56ddad762c63b8323e8646bc7cca48/macports-ports (master):

gegl: add patch to fix build with LIBRAW 0.21

Update Merge: ​https://gitlab.gnome.org/GNOME/gegl/-/merge_requests/133

Closes: #66667