Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#66677 closed update (fixed)

rpki-client update to 8.2 related

Reported by: artkiver (グレェ) Owned by: artkiver (グレェ)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: rpki-client

Description

So, I submitted a PR for updating rpki-client to version 8.2 here:

https://github.com/macports/macports-ports/pull/16987

Though that was at the time, known to not really be ideal. I figure documenting my thought process on Trac might be another place to brain storm it and solicit input from others.

Essentially, as mentioned in the comment in that PR:

It builds OK with LibreSSL, it also builds OK with OpenSSL3 with the caveat that LibreTLS needs to also be installed in that instance; but the libssl.dylib doesn't quite seem sophisticated enough to handle that and I am not sure what a good way to express that in the Portfile is?

Attachments (5)

Portfile.diff.rpkiclient.8.2 (959 bytes) - added by artkiver (グレェ) 16 months ago.
diff to upgrade rpki-client to 8.2 using openssl and libretls
Portfile.rpki-client.8.2.libressl-develOK (1.2 KB) - added by artkiver (グレェ) 16 months ago.
diff to update rpki-client Portfile to version 8.2 using the dylib which functions OK with libressl-devel (and libressl) but not with openssl because the dylib doesn't specify that libretls needs to be installed.
Portfile.diff.rpki-client.now_with_variants (1.4 KB) - added by artkiver (グレェ) 16 months ago.
diff to 7.2 Portfile to update to 8.2 adding variants for libressl, libressldevel and openssl and associated conflicts
Portfile.rpki-client8.2.diff (2.2 KB) - added by artkiver (グレェ) 16 months ago.
diff for rpki-client 7.4 to 8.2 with variants improved with neverpanic's suggestions
rpki-client.Portfilerevised (2.2 KB) - added by artkiver (グレェ) 16 months ago.
The 8.2 Portfile lint --nitpick clean and with neverpanic's suggestions for improvement

Download all attachments as: .zip

Change History (9)

Changed 16 months ago by artkiver (グレェ)

diff to upgrade rpki-client to 8.2 using openssl and libretls

Changed 16 months ago by artkiver (グレェ)

diff to update rpki-client Portfile to version 8.2 using the dylib which functions OK with libressl-devel (and libressl) but not with openssl because the dylib doesn't specify that libretls needs to be installed.

Changed 16 months ago by artkiver (グレェ)

diff to 7.2 Portfile to update to 8.2 adding variants for libressl, libressldevel and openssl and associated conflicts

comment:1 Changed 16 months ago by artkiver (グレェ)

OK, due to wonkiness between GitHub and me trying, unsuccessfully, to amend my local commits and push them into my previous PR, here's a link to a PR which is at least passing the CI buildbots checks:

https://github.com/macports/macports-ports/pull/17298

Basically, thanks to @neverpanic: added some variants and their respective conflicts to ameliorate issues that dylib isn't quite smart enough to handle.

Also added a default variant, so that the buildbots don't attempt to build without *any* TLS library, which understandably, would fail.

Changed 16 months ago by artkiver (グレェ)

diff for rpki-client 7.4 to 8.2 with variants improved with neverpanic's suggestions

Changed 16 months ago by artkiver (グレェ)

Attachment: rpki-client.Portfilerevised added

The 8.2 Portfile lint --nitpick clean and with neverpanic's suggestions for improvement

comment:2 Changed 16 months ago by artkiver (グレェ)

Closed 17298 PR.

Opened: https://github.com/macports/macports-ports/pull/17311

Which hopefully will be a bit cleaner?

CI buildbot checks passed, which is hopefully a good sign.

*sigh* hopefully I can get this GitHub and git stuff sorted out a bit better in the future, but this was not one of those times (again).

comment:3 Changed 16 months ago by artkiver (グレェ)

Resolution: fixed
Status: assignedclosed

In 99fcb7dee3592d08921ec852573a84c2e0bf492e/macports-ports (master):

rpki-client: update to version 8.2

  • closes: #66677
  • add variants for libressl, openssl (requires libretls)
  • add maintainer
  • added default_variants +libressl to appease the CI buildbots
  • other sanity improvements as suggested by neverpanic in closed PR 17298.

comment:4 Changed 16 months ago by jmroot (Joshua Root)

Port: rpki-client added
Note: See TracTickets for help on using tickets.