netcdf @4.9.2 +hdf4: variant does not install, checksum error

[cdholmes (Christopher Holmes)]

The netcdf port does not install when +hdf4 variant is requested. The default port variant (i.e. without +hdf4) installs without errors. The installation fails at the checksum verification with error "No checksum set for... ".

I include here the terminal message, key lines from the log file, and the complete log file is attached.

Terminal Message:

$ sudo port install netcdf +hdf4
--->  Computing dependencies for netcdf
--->  Fetching archive for netcdf
--->  Attempting to fetch netcdf-4.9.2_0+cdf5+dap+hdf4+netcdf4.darwin_22.x86_64.tbz2 from https://packages.macports.org/netcdf
--->  Attempting to fetch netcdf-4.9.2_0+cdf5+dap+hdf4+netcdf4.darwin_22.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/netcdf
--->  Attempting to fetch netcdf-4.9.2_0+cdf5+dap+hdf4+netcdf4.darwin_22.x86_64.tbz2 from http://mirror.fcix.net/macports/packages/netcdf
--->  Fetching distfiles for netcdf
--->  Attempting to fetch patch-liblib-CMakeLists.txt.diff from https://distfiles.macports.org/netcdf
--->  Attempting to fetch patch-liblib-CMakeLists.txt.diff from https://codeload.github.com/Unidata/netcdf-c/legacy.tar.gz/v4.9.2?dummy=
--->  Attempting to fetch netcdf-c-4.9.2.tar.gz from https://distfiles.macports.org/netcdf   
--->  Verifying checksums for netcdf                                                 
Error: No checksum set for patch-liblib-CMakeLists.txt.diff
Error: No checksum set for netcdf-c-4.9.2.tar.gz
Error: Failed to checksum netcdf: Unable to verify file checksums
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_netcdf/netcdf/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port netcdf failed

Key lines from the log file:

:notice:checksum --->  Verifying checksums for netcdf
:debug:checksum Executing org.macports.checksum (netcdf)
:info:checksum --->  Checksumming patch-liblib-CMakeLists.txt.diff
:error:checksum No checksum set for patch-liblib-CMakeLists.txt.diff
:info:checksum --->  Checksumming netcdf-c-4.9.2.tar.gz
:error:checksum No checksum set for netcdf-c-4.9.2.tar.gz
:info:checksum The correct checksum line may be:
:info:checksum checksums           patch-liblib-CMakeLists.txt.diff \
:info:checksum                     rmd160  ddc9cb923fb00d711606212bf8fe372bbf522ad4 \
:info:checksum                     sha256  88402a4d92caaa10bc0872e428c086e8c1f34651bd27ef6c4b643c5f0b3d7a04 \
:info:checksum                     size    19530033 \
:info:checksum                     netcdf-c-4.9.2.tar.gz \
:info:checksum                     rmd160  ddc9cb923fb00d711606212bf8fe372bbf522ad4 \
:info:checksum                     sha256  88402a4d92caaa10bc0872e428c086e8c1f34651bd27ef6c4b643c5f0b3d7a04 \
:info:checksum                     size    19530033
:error:checksum Failed to checksum netcdf: Unable to verify file checksums

[ryandesign (Ryan Carsten Schmidt)]

The patch-liblib-CMakeLists.txt.diff file was deleted when the port was updated to 4.9.2 but the reference to the patch in the +hdf4 variant was not. The PR said the patch was deleted because it was not used, but that doesn't appear to be true.

[ryandesign (Ryan Carsten Schmidt)]

In c7662bb13679f8df00b53277e70e1e9e89816ee5/macports-ports (master):

netcdf: Revert deletion of not-unused patchfile

Closes: #67232

[remkos (Remko Scharroo)]

Mea culpa! I did not notice the reference to that patch lower down the Portfile.

[cdholmes (Christopher Holmes)]

Thank you for the quick resolution!