openjdk8 @8u372 patch: **** misordered hunks! output would be garbled

[dbl001 (dbl)]

Possibly related to: #66988 closed defect (fixed) MacOS Ventura 13.3.1

% sudo port -vv install openjdk8
--->  Computing dependencies for openjdk8.
--->  Fetching archive for openjdk8
--->  openjdk8-8u372_0+release+server.darwin_22.x86_64.tbz2 doesn't seem to exist in /opt/local/var/macports/incoming/verified
--->  Attempting to fetch openjdk8-8u372_0+release+server.darwin_22.x86_64.tbz2 from https://packages.macports.org/openjdk8
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   126    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch openjdk8-8u372_0+release+server.darwin_22.x86_64.tbz2 from http://mirror.fcix.net/macports/packages/openjdk8
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   153    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch openjdk8-8u372_0+release+server.darwin_22.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/openjdk8
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   153    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Fetching distfiles for openjdk8
--->  Verifying checksums for openjdk8
--->  Checksumming jdk8u372-ga.tar.gz
--->  Extracting openjdk8
--->  Extracting jdk8u372-ga.tar.gz
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_java_openjdk8/openjdk8/work" && /usr/bin/gzip -dc '/opt/local/var/macports/distfiles/openjdk8/jdk8u372-ga.tar.gz' | /usr/bin/tar -xf - 
--->  Applying patches to openjdk8
--->  Applying 0001-8181503-Can-t-compile-hotspot-with-c-11.patch
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_java_openjdk8/openjdk8/work/jdk8u-jdk8u372-ga" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/java/openjdk8/files/0001-8181503-Can-t-compile-hotspot-with-c-11.patch'
patching file 'hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp'
patching file 'hotspot/src/share/vm/code/compiledIC.cpp'
--->  Applying 0002-Support-XCode-3-14.patch
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_java_openjdk8/openjdk8/work/jdk8u-jdk8u372-ga" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/java/openjdk8/files/0002-Support-XCode-3-14.patch'
patching file 'common/autoconf/generated-configure.sh'
patching file 'common/autoconf/toolchain.m4'
--->  Applying 0003-Ignore-__NSAutoreleaseNoPool-errors.patch
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_java_openjdk8/openjdk8/work/jdk8u-jdk8u372-ga" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/java/openjdk8/files/0003-Ignore-__NSAutoreleaseNoPool-errors.patch'
patching file 'common/autoconf/boot-jdk.m4'
patching file 'common/autoconf/generated-configure.sh'
patch: **** misordered hunks! output would be garbled
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_java_openjdk8/openjdk8/work/jdk8u-jdk8u372-ga" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/java/openjdk8/files/0003-Ignore-__NSAutoreleaseNoPool-errors.patch'
Exit code: 2
Error: Failed to patch openjdk8: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_java_openjdk8/openjdk8/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port openjdk8 failed

[ryandesign (Ryan Carsten Schmidt)]

Replying to dbl001:

Possibly related to: #66988

Nope.

patching file 'common/autoconf/boot-jdk.m4'
patching file 'common/autoconf/generated-configure.sh'
patch: **** misordered hunks! output would be garbled

Ventura's patch program is pickier than that of earlier macOS versions. Looking at the log from the build on Monterey:

patching file common/autoconf/boot-jdk.m4
patching file common/autoconf/generated-configure.sh
Hunk #1 succeeded at 20360 (offset 55 lines).
Hunk #2 succeeded at 20512 (offset 66 lines).
Hunk #3 succeeded at 20703 (offset 66 lines).
Hunk #4 succeeded at 20855 (offset 77 lines).
Hunk #5 succeeded at 21043 (offset 88 lines).
Hunk #6 succeeded at 21195 (offset 99 lines).
Hunk #7 succeeded at 21242 (offset 99 lines).
Hunk #8 succeeded at 21394 (offset 110 lines).
Hunk #9 succeeded at 21581 (offset 110 lines).
Hunk #10 succeeded at 21733 (offset 121 lines).
Hunk #11 succeeded at 21807 (offset 121 lines).
Hunk #12 succeeded at 21959 (offset 132 lines).
Hunk #13 succeeded at 21998 (offset 132 lines).
Hunk #14 succeeded at 22150 (offset 143 lines).
Hunk #15 succeeded at 22217 (offset 143 lines).
Hunk #16 succeeded at 22369 (offset 154 lines).
Hunk #17 succeeded at 22408 (offset 154 lines).
Hunk #18 succeeded at 22560 (offset 165 lines).
Hunk #19 succeeded at 22627 (offset 165 lines).
Hunk #20 succeeded at 22779 (offset 176 lines).
Hunk #21 succeeded at 22818 (offset 176 lines).
Hunk #22 succeeded at 22970 (offset 187 lines).
Hunk #23 succeeded at 23037 (offset 187 lines).
Hunk #24 succeeded at 23189 (offset 198 lines).
Hunk #25 succeeded at 23228 (offset 198 lines).
Hunk #26 succeeded at 23380 (offset 209 lines).
Hunk #27 succeeded at 23434 (offset 209 lines).
Hunk #28 succeeded at 23586 (offset 220 lines).
Hunk #29 succeeded at 23623 (offset 220 lines).
Hunk #30 succeeded at 23775 (offset 231 lines).
Hunk #31 succeeded at 23830 (offset 231 lines).
Hunk #32 succeeded at 23982 (offset 242 lines).
Hunk #33 succeeded at 24019 (offset 242 lines).
Hunk #34 succeeded at 24171 (offset 253 lines).
Hunk #35 succeeded at 24225 (offset 253 lines).
Hunk #36 succeeded at 24377 (offset 264 lines).
Hunk #37 succeeded at 24414 (offset 264 lines).
Hunk #38 succeeded at 24566 (offset 275 lines).
Hunk #39 succeeded at 24621 (offset 275 lines).
Hunk #40 succeeded at 24773 (offset 286 lines).
Hunk #41 succeeded at 24810 (offset 286 lines).
Hunk #42 succeeded at 24962 (offset 297 lines).
Hunk #43 succeeded at 24998 (offset 297 lines).
Hunk #44 succeeded at 25150 (offset 308 lines).

@usersxx, try regenerating the patch so that it applies without offsets.

[ryandesign (Ryan Carsten Schmidt)]

In 89577c32af7ea21d0466874ff07dfd40ed3ca4b5/macports-ports (master):

openjdk8: Refresh patchfiles

Closes: #67344