Update of oneTBB has broken rocksdb

[barracuda156]

CMake Error at /opt/local/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find TBB (missing: TBB_LIBRARIES TBB_INCLUDE_DIRS)
Call Stack (most recent call first):
  /opt/local/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindTBB.cmake:21 (find_package_handle_standard_args)
  CMakeLists.txt:431 (find_package)


-- Configuring incomplete, errors occurred!

[catap (Kirill A. Korinsky)]

In 7f15fd9dcb99e645a7ae5cc34e11cf2ebbd7c0f3/macports-ports (master):

rocksdb: update to 8.1.1; use the right TBB

Also backport patch to fix build on the latest SDK

Closes: #67389

[neverpanic (Clemens Lang)]

This version of rocksdb does not compile for me on arm64 Monterey, Apple clang version 14.0.0 (clang-1400.0.29.202):

In file included from /Users/clemens/Development/rocksdb/test_util/secondary_cache_test_util.cc:6:
/Users/clemens/Development/rocksdb/test_util/secondary_cache_test_util.h:59:16: error: no member named 'hash_seed' in 'rocksdb::LRUCacheOptions'
      lru_opts.hash_seed = 0;  // deterministic tests
      ~~~~~~~~ ^
/Users/clemens/Development/rocksdb/test_util/secondary_cache_test_util.h:63:23: error: no member named 'MakeSharedCache' in 'rocksdb::LRUCacheOptions'
      return lru_opts.MakeSharedCache();
             ~~~~~~~~ ^
/Users/clemens/Development/rocksdb/test_util/secondary_cache_test_util.h:67:15: error: no member named 'hash_seed' in 'rocksdb::HyperClockCacheOptions'
      hc_opts.hash_seed = 0;  // deterministic tests
      ~~~~~~~ ^
/Users/clemens/Development/rocksdb/test_util/secondary_cache_test_util.h:94:12: error: no member named 'secondary_cache' in 'rocksdb::ShardedCacheOptions'
      opts.secondary_cache = secondary_cache;
      ~~~~ ^
/Users/clemens/Development/rocksdb/test_util/secondary_cache_test_util.cc:62:11: error: no matching constructor for initialization of 'Cache::CacheItemHelper'
          Cache::CacheItemHelper{static_cast<CacheEntryRole>(i),
          ^                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/local/include/rocksdb/advanced_cache.h:145:24: note: candidate constructor not viable: requires at most 5 arguments, but 6 were provided
    explicit constexpr CacheItemHelper(CacheEntryRole _role,
                       ^
/opt/local/include/rocksdb/advanced_cache.h:124:10: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 6 were provided
  struct CacheItemHelper {
         ^
/opt/local/include/rocksdb/advanced_cache.h:124:10: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 6 were provided
/opt/local/include/rocksdb/advanced_cache.h:138:15: note: candidate constructor not viable: requires 0 arguments, but 6 were provided
    constexpr CacheItemHelper()
              ^
5 errors generated.
[670/721] Building CXX object CMakeFiles/db_bench.dir/tools/db_bench_tool.cc.o

This also happens when I attempt to compile the latest master branch from upstream.

[catap (Kirill A. Korinsky)]

Clemens, that is quite strange.

I've tried on my arm64 and it builds, and it also builds by buildbots: ​https://ports.macports.org/port/rocksdb/details/