gimp2,gtk3: submit latest patches to upstream

[mascguy (Christopher Nielsen)]

For their latest releases, several patches have been applied to gtk3 and gimp2. Submit PRs/MRs to upstream, in hopes of having the changes merged.

Patches for gtk3:

• patch-quartz-meson-appleframeworks.diff: patch gdk/quartz/meson.build, to make framework CoreGraphics optional; not available for 10.7 and earlier.

• patch-quartz-nseventtype.diff: patch gdk/quartz/gdkdisplaylinksource.c, to replace hard-coded use of NSEventTypeApplicationDefined, with GDK_QUARTZ_APPLICATION_DEFINED.

Patches for gimp2:

• patch-updatecheck-nsurlsession.diff: disable use of NSURLSession for macOS 10.8 and earlier; only available in 10.9 and later.

[mascguy (Christopher Nielsen)]

gtk3 patch patch-quartz-nseventtype.diff submitted to upstream:

​5958 - macOS 10.11 Quartz patch: gdkdisplaylinksource: use GDK_QUARTZ_APPLICATION_DEFINED, rather than NSEventTypeApplicationDefined

[mascguy (Christopher Nielsen)]

gtk3 patch patch-quartz-meson-appleframeworks.diff submitted to upstream:

​5959 - macOS 10.7 Quartz patch: gdk/quartz/meson.build: make dependency CoreGraphics optional

[mascguy (Christopher Nielsen)]

gimp2 patch patch-updatecheck-nsurlsession.diff submitted to upstream:

​913 - macOS 10.8 patch: app/gimp-update.c: disable update check for 10.8 and earlier, since NSURLSession isn't available

[Christopher Nielsen <mascguy@…>]

In 808bf02dd384bca17589b55a827cecec242eb594/macports-ports (master):

gimp2*: patches: add upstream detail
See: #67408

[Christopher Nielsen <mascguy@…>]

In 5a2012e4eeba7af4d71fef1b93d3616edf85fded/macports-ports (master):

gtk3*: patches: add upstream detail
See: #67408

[mascguy (Christopher Nielsen)]

Observers: While all of the patches have been submitted, let's keep this open until all have been accepted.

[Christopher Nielsen <mascguy@…>]

In 378b7274634aa891cf0a1f7ae40f8dc6e79ca721/macports-ports (master):

gtk3*: quartz: don't require CoreGraphics for 10.7 and earlier
See: #67408#comment:10

[rmottola (Riccardo)]

some 10.5/10.6 replacement methods

[rmottola (Riccardo)]

other minor 10.5/10.6 replacement

[rmottola (Riccardo)]

in updateLayer, I get an issue casting from and to CGRect and NSRect... I didn't get it. The method convertRectToBacking I supply is correctly taking and giving NSRect.

Is the compiler more sensitive?

I tried this now:

  CGRect backing_bounds = NSRectToCGRect([self convertRectToBacking: NSRectFromCGRect(layer_bounds)]);

[rmottola (Riccardo)]

ignore 10.7+ format attribute if not supported

[rmottola (Riccardo)]

futher replacements for 10.5/10.6

[rmottola (Riccardo)]

also consider this: ​https://trac.macports.org/ticket/68017

[lukaso (Lukas Oberhuber)]

In 808bf02dd384bca17589b55a827cecec242eb594/macports-ports (master):

gimp2*: patches: add upstream detail See: #67408

I looked at this patch just now, and we didn't accept it at the time because it had a few comments to fix. Here's a direct link: ​https://gitlab.gnome.org/GNOME/gimp/-/merge_requests/913. Looks like we all forgot about it after that.

Since then we've stopped supporting GIMP 2.10 on MacOS (I simply don't have time and there's just me) and focused all efforts on GIMP 3. Doesn't mean a fixed patch can't be accepted, but it's low priority now. The last official GIMP version for Mac is and will be 2.10.38.1.