Opened 11 months ago
Closed 11 months ago
#67505 closed defect (fixed)
openal-soft uses libdispatch unconditionally, which breaks build on PPC and <10.6
| Reported by: | barracuda156 | Owned by: | barracuda156 |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.8.1 |
| Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt) | |
| Port: | openal-soft |
Description
Assigning to myself for now, I will try to handle it, we have some examples for that.
Specifically, this file breaks the build, using libdispatch-specific defines for all __APPLE__:
openal-soft-1.23.0/common/threads.cpp
Change History (2)
comment:1 Changed 11 months ago by barracuda156
comment:2 Changed 11 months ago by barracuda156
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
And then we have all these errors:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp: In function 'void alSourcePlayAtTimeSOFT(ALuint, ALint64SOFT)': :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:3283:74: error: expected ')' before 'PRId64' :info:build 3283 | return context->setError(AL_INVALID_VALUE, "Invalid time point %" PRId64, start_time); :info:build | ~ ^~~~~~~ :info:build | ) :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:74:1: note: 'PRId64' is defined in header '<cinttypes>'; did you forget to '#include <cinttypes>'? :info:build 73 | #include "ringbuffer.h" :info:build +++ |+#include <cinttypes> :info:build 74 | #include "threads.h" :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:3283:72: warning: spurious trailing '%' in format [-Wformat=] :info:build 3283 | return context->setError(AL_INVALID_VALUE, "Invalid time point %" PRId64, start_time); :info:build | ^ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:3283:52: warning: too many arguments for format [-Wformat-extra-args] :info:build 3283 | return context->setError(AL_INVALID_VALUE, "Invalid time point %" PRId64, start_time); :info:build | ^~~~~~~~~~~~~~~~~~~~~~ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/core/except.h:29:53: warning: protected visibility attribute not supported in this configuration; ignored [-Wattributes] :info:build 29 | #define END_API_FUNC catch(...) { std::terminate(); } :info:build | ^ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/filter.cpp:707:1: note: in expansion of macro 'END_API_FUNC' :info:build 707 | END_API_FUNC :info:build | ^~~~~~~~~~~~ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp: In function 'void alSourcePlayAtTimevSOFT(ALsizei, const ALuint*, ALint64SOFT)': :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:3339:74: error: expected ')' before 'PRId64' :info:build 3339 | return context->setError(AL_INVALID_VALUE, "Invalid time point %" PRId64, start_time); :info:build | ~ ^~~~~~~ :info:build | ) :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:3339:75: note: 'PRId64' is defined in header '<cinttypes>'; did you forget to '#include <cinttypes>'? :info:build 3339 | return context->setError(AL_INVALID_VALUE, "Invalid time point %" PRId64, start_time); :info:build | ^~~~~~ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:3339:72: warning: spurious trailing '%' in format [-Wformat=] :info:build 3339 | return context->setError(AL_INVALID_VALUE, "Invalid time point %" PRId64, start_time); :info:build | ^ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/source.cpp:3339:52: warning: too many arguments for format [-Wformat-extra-args] :info:build 3339 | return context->setError(AL_INVALID_VALUE, "Invalid time point %" PRId64, start_time); :info:build | ^~~~~~~~~~~~~~~~~~~~~~ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/filter.cpp: In function 'void alGenFilters(ALsizei, ALuint*)': :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/core/except.h:29:53: warning: protected visibility attribute not supported in this configuration; ignored [-Wattributes] :info:build 29 | #define END_API_FUNC catch(...) { std::terminate(); } :info:build | ^ :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_openal-soft/openal-soft/work/openal-soft-1.23.0/al/filter.cpp:442:1: note: in expansion of macro 'END_API_FUNC' :info:build 442 | END_API_FUNC :info:build | ^~~~~~~~~~~~