Opened 11 months ago

Closed 8 months ago

#67567 closed defect (fixed)

vim @9.0.1499 fails to patch

Reported by: papadil Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 2.8.1
Keywords: Cc:
Port: vim

Description (last modified by ryandesign (Ryan Carsten Schmidt))

New version of vim fails to build due to patches:

--->  Applying patches to vim
Error: Failed to patch vim: command execution failed

Attachments (2)

main.log (7.4 KB) - added by saherr1969 (Stephen H) 11 months ago.
full path: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_vim/vim/main.log
Portfile (8.9 KB) - added by papadil 11 months ago.
vim portfile mod to compile w/o the offending patches.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 months ago by ryandesign (Ryan Carsten Schmidt)

Cc: raimue@… removed
Description: modified (diff)
Owner: set to raimue
Port: @9.0.1499 removed
Status: newassigned
Summary: vim @9.0.1499 fails to buildvim @9.0.1499 fails to patch

You didn't attach the main.log file so I don't know which patch failed to apply, but see if https://github.com/macports/macports-ports/pull/18934 fixes it.

comment:2 Changed 11 months ago by Gandoon (Erik Hedlund)

I manually applied the content of the patch to the first occurrence of the patch substitution. The line numbers differ in the distributed files to the ones in the .diff file. The manual approach worked, but it is not ideal. Maybe the mentioned PR is a better solution.

Do note, in the file to which the patch is supposed to be applied there are actually two locations that potentially could have the same substitution applied. Thus I am somewhat unsure if the substitution should actually have been done in both locations. The patch seems to only target one location, so that is what I did.

comment:3 Changed 11 months ago by papadil

FYI: I disabled the patches in my local macports portfile - it compiles and works just fine with +lua+python311.

Changed 11 months ago by saherr1969 (Stephen H)

Attachment: main.log added

full path: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_vim/vim/main.log

Changed 11 months ago by papadil

Attachment: Portfile added

vim portfile mod to compile w/o the offending patches.

comment:4 Changed 11 months ago by papadil

Attached the portfile with two patch lines commented out. Works on my Mac x86_64, latest OS Ventura.

comment:5 Changed 11 months ago by markmentovai (Mark Mentovai)

This should be fixed as of 760cfe85cfdfe7b88ee9b92a8e15695a79d6af0b (#18934).

comment:6 in reply to:  5 Changed 8 months ago by mascguy (Christopher Nielsen)

Resolution: fixed
Status: assignedclosed

Replying to markmentovai:

This should be fixed as of PR 18934.

Yes indeed, closing as fixed.

Note: See TracTickets for help on using tickets.