Unable to upgrade rust to 1.70.0_0

[RobK88]

I am unable to upgrade rust from 1.69.0_1 to 1.70.0_0 on High Sierra (x86_64).

It looks like a problem with the bootstrap.

See attached main.log for more details.

:info:build [144/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Program.cpp.o
:info:build FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/Program.cpp.o 
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/compwrap/cxx/usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src/build/x86_64-apple-darwin/llvm/build/lib/Support -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src/src/llvm-project/llvm/lib/Support -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src/build/x86_64-apple-darwin/llvm/build/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src/src/llvm-project/llvm/include -isystem /opt/local/include -ffunction-sections -fdata-sections -fPIC --target=x86_64-apple-darwin -stdlib=libc++  -Os -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -w -fdiagnostics-color  -O3 -DNDEBUG -mmacosx-version-min=10.13 -std=c++17  -fno-exceptions -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/Program.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/Program.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/Program.cpp.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src/src/llvm-project/llvm/lib/Support/Program.cpp
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src/src/llvm-project/llvm/lib/Support/Program.cpp:46:49: error: no viable constructor or deduction guide for deduction of template arguments of 'optional'
:info:build         PI, SecondsToWait == 0 ? std::nullopt : std::optional(SecondsToWait),
:info:build                                                 ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:684:41: note: candidate template ignored: couldn't infer template argument '_Tp'
:info:build     _LIBCPP_INLINE_VISIBILITY constexpr optional(nullopt_t) noexcept {}
:info:build                                         ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:690:24: note: candidate template ignored: couldn't infer template argument '_Tp'
:info:build     constexpr explicit optional(in_place_t, _Args&&... __args)
:info:build                        ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:704:15: note: candidate template ignored: couldn't infer template argument '_Tp'
:info:build     constexpr optional(_Up&& __v)
:info:build               ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:711:24: note: candidate template ignored: couldn't infer template argument '_Tp'
:info:build     constexpr explicit optional(_Up&& __v)
:info:build                        ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:580:7: note: candidate template ignored: could not match 'optional<_Tp>' against 'unsigned int'
:info:build class optional
:info:build       ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:682:41: note: candidate template ignored: could not match 'optional<_Tp>' against 'unsigned int'
:info:build     _LIBCPP_INLINE_VISIBILITY constexpr optional(const optional&) = default;
:info:build                                         ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:683:41: note: candidate template ignored: could not match 'optional<_Tp>' against 'unsigned int'
:info:build     _LIBCPP_INLINE_VISIBILITY constexpr optional(optional&&) = default;
:info:build                                         ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:719:5: note: candidate template ignored: could not match 'optional<type-parameter-0-1>' against 'unsigned int'
:info:build     optional(const optional<_Up>& __v)
:info:build     ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:727:14: note: candidate template ignored: could not match 'optional<type-parameter-0-1>' against 'unsigned int'
:info:build     explicit optional(const optional<_Up>& __v)
:info:build              ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:737:5: note: candidate template ignored: could not match 'optional<type-parameter-0-1>' against 'unsigned int'
:info:build     optional(optional<_Up>&& __v)
:info:build     ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:745:14: note: candidate template ignored: could not match 'optional<type-parameter-0-1>' against 'unsigned int'
:info:build     explicit optional(optional<_Up>&& __v)
:info:build              ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:681:41: note: candidate function template not viable: requires 0 arguments, but 1 was provided
:info:build     _LIBCPP_INLINE_VISIBILITY constexpr optional() noexcept {}
:info:build                                         ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:697:24: note: candidate function template not viable: requires at least 2 arguments, but 1 was provided
:info:build     constexpr explicit optional(in_place_t, initializer_list<_Up> __il, _Args&&... __args)
:info:build                        ^
:info:build 1 error generated.
:info:build [145/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Signals.cpp.o
:info:build ninja: build stopped: subcommand failed.
:info:build thread 'main' panicked at '
:info:build command did not execute successfully, got: exit status: 1
:info:build build script failed, must exit now', /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/.home/.cargo/macports/cmake-0.1.48/src/lib.rs:975:5
:info:build stack backtrace:
:info:build    0: rust_begin_unwind
:info:build              at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/panicking.rs:579:5
:info:build    1: core::panicking::panic_fmt
:info:build              at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/panicking.rs:64:14
:info:build    2: cmake::fail
:info:build    3: cmake::run
:info:build    4: cmake::Config::build
:info:build    5: <bootstrap::llvm::Llvm as bootstrap::builder::Step>::run
:info:build              at ./src/bootstrap/llvm.rs:488:9
:info:build    6: bootstrap::builder::Builder::ensure
:info:build              at ./src/bootstrap/builder.rs:2039:23
:info:build    7: bootstrap::compile::rustc_llvm_env
:info:build              at ./src/bootstrap/compile.rs:898:48
:info:build    8: bootstrap::compile::rustc_cargo_env
:info:build              at ./src/bootstrap/compile.rs:885:13
:info:build    9: bootstrap::compile::rustc_cargo
:info:build              at ./src/bootstrap/compile.rs:822:5
:info:build   10: <bootstrap::compile::Rustc as bootstrap::builder::Step>::run
:info:build              at ./src/bootstrap/compile.rs:699:9
:info:build   11: bootstrap::builder::Builder::ensure
:info:build              at ./src/bootstrap/builder.rs:2039:23
:info:build   12: <bootstrap::compile::Assemble as bootstrap::builder::Step>::run
:info:build              at ./src/bootstrap/compile.rs:1398:9
:info:build   13: bootstrap::builder::Builder::ensure
:info:build              at ./src/bootstrap/builder.rs:2039:23
:info:build   14: bootstrap::builder::Builder::compiler
:info:build              at ./src/bootstrap/builder.rs:952:9
:info:build   15: <bootstrap::compile::Assemble as bootstrap::builder::Step>::run
:info:build              at ./src/bootstrap/compile.rs:1382:30
:info:build   16: bootstrap::builder::Builder::ensure
:info:build              at ./src/bootstrap/builder.rs:2039:23
:info:build   17: bootstrap::builder::Builder::compiler
:info:build              at ./src/bootstrap/builder.rs:952:9
:info:build   18: <bootstrap::compile::Std as bootstrap::builder::Step>::make_run
:info:build              at ./src/bootstrap/compile.rs:71:23
:info:build   19: bootstrap::builder::StepDescription::maybe_run
:info:build              at ./src/bootstrap/builder.rs:301:13
:info:build   20: bootstrap::builder::StepDescription::run
:info:build              at ./src/bootstrap/builder.rs:338:21
:info:build   21: bootstrap::builder::Builder::run_step_descriptions
:info:build              at ./src/bootstrap/builder.rs:944:9
:info:build   22: bootstrap::builder::Builder::execute_cli
:info:build              at ./src/bootstrap/builder.rs:924:9
:info:build   23: bootstrap::Build::build
:info:build              at ./src/bootstrap/lib.rs:693:13
:info:build   24: bootstrap::main
:info:build              at ./src/bootstrap/bin/main.rs:58:5
:info:build   25: core::ops::function::FnOnce::call_once
:info:build              at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/ops/function.rs:250:5
:info:build note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
:info:build 	finished in 177.939 seconds
:info:build Build completed unsuccessfully in 0:07:03
:info:build make: *** [all] Error 1
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/work/rustc-1.70.0-src" && /usr/bin/make -j2 -w all BOOTSTRAP_ARGS="-j2" 
:info:build Exit code: 2
:error:build Failed to build rust: command execution failed
:debug:build Error code: CHILDSTATUS 50073 2
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "system {*}$notty {*}$callback {*}$nice $fullcmdstring"
:debug:build     invoked from within
:debug:build "command_exec -callback portprogress::target_progress_callback build"
:debug:build     (procedure "portbuild::build_main" line 8)
:debug:build     invoked from within
:debug:build "$procedure $targetname"
:error:build See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_rust/rust/main.log for details.

[RobK88]

main.log

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

I am afraid I cannot reproduce this error.
However, rust has now ​built successfully on the buldbots, so if you try again, you should be able to download the prebuilt binaries.

[RobK88]

Thanks. But for some reason, MacPorts will NOT download the pre-built binaries for rust. It insists on building it from source!

I do not know why. I am not using any variants.

port installed rust
The following ports are currently installed:
  rust @1.69.0_1 (active)

I will try again but this time I will specify clang-16. (FYI -- High Sierra uses clang-10 by default).

Compiling now. Crossing my fingers!

[RobK88]

So far, the upgrade to rust 1.70.0 is working after I specified clang-16 as the compiler to use.

Clang-16 was able to compile Program.cpp.o (where it failed last time using clang-10).

The compile is still in progress. I will let you know what happens,

But it looks like you may need to blacklist some compilers in the Portfile.

[RobK88]

Yes, I can confirm that I was able to upgrade rust to version 1.70.0_0 using clang-16. That is, I used the following to upgrade rust on my Mac running High Sierra.

sudo port -vs upgrade rust configure.compiler=macports-clang-16

$ rustc --version
rustc 1.70.0 (90c541806 2023-05-31) (built from a source tarball)

So it looks like the default compiler on High Sierra (clang-10) is unable to compile rust version 1.70.0.

$ cc --version
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Grinchs-MacBook-Pro:~ rob$ 
Grinchs-MacBook-Pro:~ rob$ clang --version
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

You may want to consider blacklisting clang-10 in the Portfile for rust. You might need to blacklist other compiler as well.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

I am glad it is working for you.
If I could ask your help in tracking down which compilers to blacklist, I would appreciate it.
I am unable to reproduce the problem.
I see from the log file that you have the developer tools installed, and that is what is being used to compile Rust.
Could you please post the result of

DEVELOPER_DIR='/Library/Developer/CommandLineTools' cc --version

This should give slightly different results from the ones you posted earlier.

[RobK88]

Marcus, here the the output of the command:

$ DEVELOPER_DIR='/Library/Developer/CommandLineTools' cc --version
Apple LLVM version 10.0.0 (clang-1000.10.44.4)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

To be honest, I am a little baffled. I see that the buildbot was able to build rust version 1.70.0_0 just fine on High Sierra. There must be something else going on with my Mac causing the build to fail when using the default clang-10 compiler on High Sierra.

[RobK88]

P.S. I also do not know whet MacPorts insists on building rust from source, instead of downloading the prebuilt binaries.

The only thing that I can see that is different in my build environment from the buildbot build environment is some of the dependencies needed to build rust on my Mac were built using the +universal variant. Maybe that is the reason for the all the rust related issues on my Mac.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

The buildbot is using ​Xcode 9.4.1, CLT 9.4.1.0.1.1528165917, so Rust's compiler.cxx_standard 2017 causes MacPorts to use clang-16, which, as you note, works fine.
Both your setup and mine use Xcode 10.1, CLT 10.1.0.0.1.1539992718.
Why my setup works and yours does not is a bit of a mystery.

From what I can tell in your build log, Rust was not downloaded as a binary because it was, at that time, unavailable.

:info:archivefetch --->  rust-1.70.0_0.darwin_17.x86_64.tbz2 doesn't seem to exist in /opt/local/var/macports/incoming/verified
:msg:archivefetch --->  Attempting to fetch rust-1.70.0_0.darwin_17.x86_64.tbz2 from http://packages.macports.org/rust
:debug:archivefetch Fetching archive failed: The requested URL returned error: 404 Not Found
:msg:archivefetch --->  Attempting to fetch rust-1.70.0_0.darwin_17.x86_64.tbz2 from http://ywg.ca.packages.macports.org/mirror/macports/packages/rust
:debug:archivefetch Fetching archive failed: The requested URL returned error: 404 Not Found
:msg:archivefetch --->  Attempting to fetch rust-1.70.0_0.darwin_17.x86_64.tbz2 from http://mirror.fcix.net/macports/packages/rust

Why it is still a problem is also a bit of a mystery (at least to me).
MacPorts will not attempt to download a binary archive if the user has ​changed certain settings, such as delete_la_files.
But, as you again note, there is indication of that.

Now that the buildbots have done their job, is there any hint in the build logs as to why the archivefetch is failing?

[RobK88]

Since my last build was successfully, I do not have a main.log build log to look at.

And I have not modified macports.conf. My setup is just a regular pain vanilla MacPorts installation on High Sierra.

Attached is my macports.conf

[RobK88]

Marcus wrote:

The buildbot is using ​Xcode 9.4.1, CLT 9.4.1.0.1.1528165917, so Rust's `compiler.cxx_standard 2017` causes MacPorts to use `clang-16`, which, as you note, works fine.

Interesting. It is strange that I have to manually specify the clang-16 compiler when installing or upgrading rust. It should have been selected automatically without the need to specify the compiler.

[pcafstockf (Frank Stock)]

I have the exact same problem, but since I have to use a custom / multi-install of MacPorts, I cannot rely on downloading a binary archive, but must instead build from source.

Worse, this is a build for High Sierra, and Xcode 10.1 is the latest that will still run on HS. I simply do not have the option of clang-16.

Please don't blacklist clang-10, as there are many ports which seem to depend on rust (I am trying to build amavisd-new). It seems kind of un-realistic to chop off such a large number of pors which currently claim to support older platforms.

[pcafstockf (Frank Stock)]

Is it time for rust to adopt the MacPorts 'select' standard that Python, Perl, and others have adopted (e.g. rust-16, rust-17, etc.)?

[mascguy (Christopher Nielsen)]

rust was just updated to 1.71.1.

Can you folks try to build again, with this latest release?

[RobK88]

@Christopher Nielsen -- I tried to build rust @ 1.71.1 from source but it failed. See ​https://trac.macports.org/ticket/68018

I will try to build it again but this time I will specify the clang-16 compiler and I will also cross my fingers! I will report back.

P.S. MacPorts first tried to download and install the rust-1.71.1_0.darwin_17.x86_64.tbz2 package. But it does not exist on the MacPorts servers. It looks like the buildbot failed at building the rust package for High Sierra.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

#68018 marked as duplicate.

[RobK88]

It looks like the old workaround still works. If one specifies macports-clang-16 as the compiler, it looks like rust @1.71.1 will build on High Sierra. At least it was able to build past Program.cpp.o where it failed before. I am still waiting for the compile to complete. It will take some time on this old MacBook Pro.

bash-3.2$ port outdated
The following installed ports are outdated:
cargo                          0.71.0_0 < 0.72.2_0       
rust                           1.70.0_0 < 1.71.1_0       
bash-3.2$ 
bash-3.2$ sudo port clean rust
Password:
--->  Cleaning rust
bash-3.2$  
bash-3.2$ sudo port -vs upgrade rust configure.compiler=macports-clang-16
...
[143/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/RWMutex.cpp.o
[144/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Program.cpp.o
[145/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Threading.cpp.o
[146/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Valgrind.cpp.o
[147/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Watchdog.cpp.o
[148/3146] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Signals.cpp.o
[149/3146] Building C object lib/Support/BLAKE3/CMakeFiles/LLVMSupportBlake3.dir/blake3
...

[RobK88]

I can confirm that rust @1.71.1 does build successfully on High Sierra when MacPorts is told to use the macports-clang-16 compiler.

bash-3.2$ port outdated
The following installed ports are outdated:
cargo                          0.71.0_0 < 0.72.2_0       
rust                           1.70.0_0 < 1.71.1_0       
bash-3.2$ 
bash-3.2$ sudo port clean rust
Password:
--->  Cleaning rust
bash-3.2$  
bash-3.2$ sudo port -vs upgrade rust configure.compiler=macports-clang-16
....
--->  Cleaning rust
--->  Removing work directory for rust
--->  Scanning binaries for linking errors
--->  No broken files found.                             
--->  No broken ports found.
bash-3.2$ 
bash-3.2$ rustc --version
rustc 1.71.1 (eb26296b5 2023-08-03) (built from a source tarball)
bash-3.2$
bash-3.2$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G14042

[RobK88]

@Marcus - I am not sure why you are able to build rust on High Sierra on your Mac using the default compiler but I cannot. My setup is a plain vanilla install of MacPorts on my Mac running High Sierra. But some of the dependencies for rust on my Mac were built using the +universal variant. See below:

rob$ port installed cmake python311 pkgconfig ninja
The following ports are currently installed:
  cmake @3.24.4_0+universal (active)
  ninja @1.11.1_1 (active)
  pkgconfig @0.29.2_0+universal (active)
  python311 @3.11.4_0+lto+optimizations+universal (active)
rob$ 
rob$ port installed curl libiconv libgit2 zlib openssl3 
The following ports are currently installed:
  curl @8.2.1_0+http2+ssl+universal (active)
  libgit2 @1.6.4_1+threadsafe (active)
  libiconv @1.17_0+universal (active)
  openssl3 @3.1.2_0+universal (active)
  zlib @1.3_0+universal (active)

Also see:

rob$ DEVELOPER_DIR='/Library/Developer/CommandLineTools' cc --version
Apple LLVM version 10.0.0 (clang-1000.10.44.4)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

rob$ cc --version
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

rob$ which cc

rob$ ls -la /usr/bin/cc
lrwxr-xr-x  1 root  wheel  5 14 Apr  2019 /usr/bin/cc -> clang

[RobK88]

P.S. I see the prebuilt binaries for rust and cargo for High Sierra are now posted on ​https://packages.macports.org/rust/ and ​https://packages.macports.org/cargo respectively. So most High Sierra users should NOT have have any issues with installing rust and cargo on their Macs running High Sierra (unless they insist on building the binaries from source).

[pcafstockf (Frank Stock)]

@RobK88 "insist" may technically be accurate, but could imply the user is just being obstinate.
In truth, MacPorts itself requires one to build from source in some scenarios (such as a multi, or custom MacPorts installations).

I feel the need to point this out, as prebuilt binaries do not actually solve the defect in some well documented and supported MacPorts modes.

[RobK88]

Yes. "insist on building" was a port choice of words. I should have said "(unless they want to build the binaries from source or MacPorts requires that the binaries be built from source)"