Buildbot builds dependency from source when binary is available

[ryandesign (Ryan Carsten Schmidt)]

Building php82-oracle failed on the 10.7 build machine because the source of its dependency oracle-instantclient could not be fetched:

​https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/149620/steps/install-dependencies/logs/stdio

----> Installing dependency (1 of 9) 'm4' with variants ''
Already installed, nothing to do
----> Installing dependency (2 of 9) 'autoconf' with variants ''
Already installed, nothing to do
----> Installing dependency (3 of 9) 'oracle-instantclient' with variants ''
DEBUG: dropping privileges: euid changed to 502, egid changed to 501.
DEBUG: Starting logging for oracle-instantclient @11.2.0.4.0_1
DEBUG: Mac OS X 10.7.5 (darwin/11.4.2) arch i386
DEBUG: MacPorts 2.8.1
DEBUG: Xcode 4.6.3, CLT 4.6.0.0.1.1365549073
DEBUG: SDK 10.7
DEBUG: MACOSX_DEPLOYMENT_TARGET: 10.7
DEBUG: Executing org.macports.main (oracle-instantclient)
DEBUG: dropping privileges: euid changed to 502, egid changed to 501.
DEBUG: fetch phase started at Wed Jun 28 11:21:20 UTC 2023
--->  Fetching distfiles for oracle-instantclient
DEBUG: Executing org.macports.fetch (oracle-instantclient)
--->  instantclient-basic-macos.x64-11.2.0.4.0.zip does not exist in /opt/local/var/macports/distfiles/oracle-instantclient
--->  Attempting to fetch instantclient-basic-macos.x64-11.2.0.4.0.zip from http://download.oracle.com/otn/mac/instantclient/11204/
DEBUG: Fetching distfile failed: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
Error: Failed to fetch oracle-instantclient: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

Inability to fetch the source is expected for oracle-instantclient however a binary of oracle-instantclient exists on the private packages server so it's unexpected that it's trying to build from source at all.

[jmroot (Joshua Root)]

I would guess it wasn't able to contact the private packages server temporarily, so the binary was considered unavailable.

[ryandesign (Ryan Carsten Schmidt)]

I don't see how that would be possible. The two servers are located mere inches from one another. This is not the first time I've seen this either.

[jmroot (Joshua Root)]

Ah of course, the _archive_available check only considers the primary archive server.

[jmroot (Joshua Root)]

In 3a17fcd355bc88e66bff9262f42c91335d3c4b49/mpbb (master):

dependencies.tcl: always try archivefetch

The _archive_available check only looks at the public packages server.
There may still be an archive in a private location.

Fixes: #67700

[ryandesign (Ryan Carsten Schmidt)]

Thanks!