gd license should not be marked as conflicting with GPL

[szhorvat (Szabolcs Horvát)]

Currently, the gd license is marked as conflicting with the GPL, causing the gd2 port not to be distributable:

./port_binary_distributable.tcl -v gd2
"gd2" is not distributable because its license "gd" conflicts with license "GPL-2+" of dependency "x265"

However, the restrictions imposed by the gd license appear to be the same as in the 2-clause BSD license, which is GPL-compatible. Compare:

​https://github.com/libgd/libgd/blob/master/COPYING ​https://opensource.org/license/bsd-2-clause/

I suggest removing this restriction and making gd2 distributable.

[jmroot (Joshua Root)]

A difference from the BSD license is that gd's requires a notice to be distributed specifically in "user-accessible supporting documentation". That may well qualify as an "additional restriction" which the GPL would disallow.

[mohd-akram (Mohamed Akram)]

The license says "if you have questions, ask" and the ​devs seem to suggest it is equivalent to BSD-2.

[mohd-akram (Mohamed Akram)]

This particular issue was fixed by making libheif use kvazaar by default instead of x265 in [e232b99c0167098352502ad5f853689934a906e2/macports-ports]. Now we get:

$ ./port_binary_distributable.tcl -v gd2
"gd2" is not distributable because its license "gd" conflicts with license "GPL-3+" of dependency "gdbm"

AFAICT, this is coming from a perl build dependency somewhere in the tree. I have opened ​https://github.com/macports/macports-infrastructure/pull/20 which should fix this issue for this port and others by only checking the license of library dependencies. I've confirmed that it fixes it in this case:

$ ./port_binary_distributable.tcl -v gd2
"gd2" is distributable