mpich: enable F08 when updating

[barracuda156]

Please --enable-f08 when updating MPICH, it builds fine with it. We need it, because some ports are broken without F08 enabled.

Case in question DBCSR: ​https://github.com/cp2k/dbcsr/issues/661

I cannot fix the build until MPICH supports F08, since upstream solution relies on that.

[eborisch (Eric A. Borisch)]

Have you tested if any of the other ports that use fortran and mpich will break from this change?

• AlphaSparse
• NTPoly
• abinit
• bpack
• dbcsr
• feast
• ginkgo
• hiop
• hpddm
• libsc
• mumps
• p4est
• paramonte
• pfft
• psblas3
• raja
• scalapack
• starpu
• sundials2
• sundials5
• sundials6

[eborisch (Eric A. Borisch)]

Those are the ones with it on by default; there are certainly more that can use fortran and mpich in variants. I guess my point is I don't know/use fortran enough to know that this is a benign change for other packages.

[mascguy (Christopher Nielsen)]

Replying to eborisch:

Have you tested if any of the other ports that use fortran and mpich will break from this change?

That was a concern of mine too.

Would it make sense to add this via an optional variant then?

[barracuda156]

Replying to eborisch:

Have you tested if any of the other ports that use fortran and mpich will break from this change?

• AlphaSparse
• NTPoly
• abinit
• bpack
• dbcsr
• feast
• ginkgo
• hiop
• hpddm
• libsc
• mumps
• p4est
• paramonte
• pfft
• psblas3
• raja
• scalapack
• starpu
• sundials2
• sundials5
• sundials6

I literally refer to dbcsr above which is now broken because F08 is not enabled.

But I can easily test others – those are predominantly my own ports.

[barracuda156]

Replying to mascguy:

Would it make sense to add this via an optional variant then?

Unfortunately Macports does not allow requiring a variant of a port for a default build. So this won’t fix dbcsr, unless this is fixed in Macports base.

16. S. Of course it is better to have it as a variant than having it quietly disabled, but it does not fix the specific port at least.

[mascguy (Christopher Nielsen)]

Replying to barracuda156:

Replying to mascguy:

Would it make sense to add this via an optional variant then?

Unfortunately Macports does not allow requiring a variant of a port for a default build. So this won’t fix dbcsr, unless this is fixed in Macports base.

I'm not sure what you mean: You can install any subport of mpich/openmpi with whatever variants are desired, then install dependent ports.

For example:

$ sudo port -N install mpich-gcc12 +my_new_variant
$ sudo port -N dbcsr +gcc12

[mascguy (Christopher Nielsen)]

Replying to mascguy:

Replying to barracuda156:

Unfortunately Macports does not allow requiring a variant of a port for a default build. So this won’t fix dbcsr, unless this is fixed in Macports base.

I'm not sure what you mean: You can install any subport of mpich/openmpi with whatever variants are desired, then install dependent ports.

For example:

$ sudo port -N install mpich-gcc12 +my_new_variant
$ sudo port -N dbcsr +gcc12

Alternatively, using mpich-default:

$ sudo port -N install mpich-default +my_new_variant
$ sudo port -N install dbcsr

[barracuda156]

Replying to mascguy:

Replying to barracuda156:

Replying to mascguy:

Would it make sense to add this via an optional variant then?

Unfortunately Macports does not allow requiring a variant of a port for a default build. So this won’t fix dbcsr, unless this is fixed in Macports base.

I'm not sure what you mean: You can install any subport of mpich/openmpi with whatever variants are desired, then install dependent ports.

For example:

$ sudo port -N install mpich-gcc12 +my_new_variant
$ sudo port -N dbcsr +gcc12

Sorry, I mean that we cannot make dbcsr (or any port in its default config) require a non-default variant of MPICH (or any other port), at least as far as I know. I asked this question earlier re R, and Ryan said it cannot work.

Locally, of course, I can do anything. But it will leave dbcsr broken for everyone else.

[barracuda156]

Confirmed to build fine:

AlphaSparse
bpack
dbscr
hiop
NTPoly
raja
scalapack
sundial6

To be updated.

16. S. MPICH has F08 enabled by default, and that is what ports would normally expect, IMO, not a current non-default Macports setting.

UPD. So, I reckon it works perfectly fine.

[barracuda156]

Replying to mascguy:

Where are we on this? I have been using mpich 4.1.2 with enabled fortran 2008 for all this time, no issues, works nicely. It is desirable to have it updated perhaps?

[barracuda156]

Well, update ignored this, I will open a PR then. Some ports are broken otherwise, and enough time passed to test this.

[mascguy (Christopher Nielsen)]

Replying to barracuda156:

Well, update ignored this, I will open a PR then. Some ports are broken otherwise, and enough time passed to test this.

Dear Lord, updating these ports will tie up the buildbots for several days, so please don't create any new PRs.

There's a reason openmpi and mpich haven't been touched, despite being out-of-date: In addition to days of buildbot time, they also require a lot of pre-merge testing to ensure there isn't breakage across macOS releases!

*I* will take care of all of this, eventually. Patience please...

[barracuda156]

Replying to mascguy:

*I* will take care of all of this, eventually. Patience please...

Ok, got it. Will wait for your update. Thanks.

[barracuda156]

Just for the record, I have just built mpich with gcc13.

36-125% port -v installed mpich-gcc13 
The following ports are currently installed:
  mpich-gcc13 @4.1.2_0+fortran (active) requested_variants='' platform='darwin 10' archs='ppc' date='2023-10-08T01:28:48+0800'

16. S. These are also unneeded now: "F90FLAGS='' F90=''", I dropped those.

[barracuda156]

I guess, this can be closed?

[mascguy (Christopher Nielsen)]

Replying to barracuda156:

I guess, this can be closed?

Yes indeed: All of this was addressed by more recent updates, along with this commit:

mpich/doc: update to 4.1.2; drop F90/F90FLAGS