Opened 9 months ago

Last modified 9 months ago

#67769 new defect

fzf @0.42.0: missing function body

Reported by: cave-canem Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.8.1
Keywords: mavericks Cc: cave-canem, cardi (calvin ardi), herbygillot (Herby Gillot)
Port: fzf

Description

sudo port -vd upgrade fzf
...
Executing:  cd "/opt/MacPorts/var/macports/build/_opt_macports-ports_sysutils_fzf/fzf/work/gopath/src/github.com/junegunn/fzf" && /opt/MacPorts/bin/go build -ldflags "-X main.version=0.42.0 -X main.revision=MacPorts"
DEBUG: system:  cd "/opt/MacPorts/var/macports/build/_opt_macports-ports_sysutils_fzf/fzf/work/gopath/src/github.com/junegunn/fzf" && /opt/MacPorts/bin/go build -ldflags "-X main.version=0.42.0 -X main.revision=MacPorts"
# github.com/rivo/uniseg
../../rivo/uniseg/properties.go:137:6: missing function body
../../rivo/uniseg/properties.go:137:20: syntax error: unexpected [, expecting (
Command failed:  cd "/opt/MacPorts/var/macports/build/_opt_macports-ports_sysutils_fzf/fzf/work/gopath/src/github.com/junegunn/fzf" && /opt/MacPorts/bin/go build -ldflags "-X main.version=0.42.0 -X main.revision=MacPorts"
Exit code: 2
Error: Failed to build fzf: command execution failed
DEBUG: Error code: CHILDSTATUS 37527 2
DEBUG: Backtrace: command execution failed
    while executing
"system {*}$notty {*}$callback {*}$nice $fullcmdstring"
    invoked from within
"command_exec -callback portprogress::target_progress_callback build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"

Detaled (debug) log in attachment.

Attachments (1)

main.log.tar.xz (4.2 KB) - added by cave-canem 9 months ago.
main.log

Download all attachments as: .zip

Change History (3)

Changed 9 months ago by cave-canem

Attachment: main.log.tar.xz added

main.log

comment:1 Changed 9 months ago by cardi (calvin ardi)

One of fzf's dependencies, rivo/uniseg, requires Go 1.19.

It looks like you're running OS X 10.9.5---MacPorts' version of Go is fixed to 1.17.3 if you're running macOS 10.12 (Sierra) or older.

(See also #66295.)

comment:2 Changed 9 months ago by ryandesign (Ryan Carsten Schmidt)

Keywords: mavericks added; Mavericks removed
Port: @0.42.0 removed
Summary: port fzf 0.33.0_0 < 0.42.0_0 Failed to build fzffzf @0.42.0: missing function body

Please use the platforms keyword to indicate supported OS versions e.g. if this port supports OS X 10.10 (Darwin 14) and later, write platforms {darwin >= 14}. This tells the build system it needn't bother building a port on systems where it is known not to work and gives the user a better error message earlier. go modules failing to indicate this is a pervasive problem in MacPorts that needs some attention from the port maintainers.

Since the go version number seems to be the relevant piece of information, perhaps all go module ports need to indicate what minimum version of go they require, via some hypothetical future facility of the golang portgroup, and the portgroup can then set platforms correctly.

Note: See TracTickets for help on using tickets.