mosquitto: update to 2.0.20

[danh1979]

After some Internet-search-aided debugging, I found that I needed to:

• add libcjson dependency
• deal with missing symbols via the extra linker flag
• deal with an xslt error by installing docbook XSL

I tested a previous version of my patch to update to 2.0.16 on Ventura 13.5 on M2 Pro by creating my own local Portfile and installing it from source.

Recently tested update to 2.0.20 on Sonoma 14.7.1 M2 Pro.

Github merge request: ​https://github.com/macports/macports-ports/pull/26992

[ryandesign (Ryan Carsten Schmidt)]

revision should drop to 0 when the version is increased.

​http://mosquitto.org redirects to ​https://mosquitto.org so master_sites should be changed to ${homepage}/files/source/.

Needing to specify -undefined dynamic_lookup manually is surprising and suggests a bug in the build system. What error did you get before adding that? Did you file a bug report with upstream? Please provide its URL.

[danh1979]

I updated the patch with the revision and master_sites suggestions.

Regarding -undefined dynamic_lookup, it seems there are some plugins in mosquitto, written add_library(targetname MODULE ...) in cmake, where targetname is one of these three:

• mosquitto_dynamic_security
• mosquitto_message_timestamp
• mosquitto_payload_modification

These don't compile without adding -DCMAKE_MODULE_LINKER_FLAGS="-undefined dynamic_lookup".

Prompted by your suggestion, and then learning about cmake-1.1.tcl and recreating a macports-equivalent build environment, I searched the mosquitto source and found

​https://github.com/eclipse/mosquitto/blob/v2.0.15/CMakeLists.txt#L22

If I change this to

CMakeLists.txt

@@ -20 +20 @@
 endif (WIN32)
 
 if(APPLE)
-       set(CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "${CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS} -undefined dynamic_lookup")
+       set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -undefined dynamic_lookup")
 endif(APPLE)
 
 include(GNUInstallDirs)

... then mosquitto builds without -DCMAKE_MODULE_LINKER_FLAGS="-undefined dynamic_lookup" fed on the cmake command line.

[danh1979]

modified patch for this port to use a patch for mosquitto's CMakeLists.txt instead of an extra command line arg

[danh1979]

Looks like mosquitto already has an issue; I added a comment ​https://github.com/eclipse/mosquitto/issues/2858

[danh1979]

macports-ports.mosquitto-2.0.15.patch

[danh1979]

mosquitto: update to 2.0.16

[danh1979]

My patch is no longer required as of 2.0.20: ​https://github.com/ckrey/mosquitto/commit/1784294c067816d1d471241d7bd75bbb0f811702