libstemmer: does not respect MACOSX_DEPLOYMENT_TARGET or SDKROOT

[lukaso (Lukas Oberhuber)]

This means it is always built for the current SDK/OS (which breaks ability to build GIMP for older OSs.

otool -l ~/macports-gimp3-x86_64/lib/libstemmer.dylib

Output:

...

Load command 10
      cmd LC_BUILD_VERSION
  cmdsize 32
 platform 1
    minos 13.0
      sdk 13.3
   ntools 1
     tool 3
  version 857.1

...

[lukaso (Lukas Oberhuber)]

Build log from libstemmer (sorry for the file name).

[lukaso (Lukas Oberhuber)]

It needs something like:

CFLAGS += -mmacosx-version-min=$MACOSX_DEPLOYMENT_TARGET
LDFLAGS += -Wl,-macosx_version_min,$MACOSX_DEPLOYMENT_TARGET

being added to the GNUMakefile

[kencu (Ken)]

It's also not UsingTheRightCompiler:

 cc -O2 -W -Wall -Wmissing-prototypes -Wmissing-declarations   -c -o compiler/space.o compiler/space.c

[kencu (Ken)]

adding the Makefile 1.0 PG helps:

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_textproc_libstemmer/libstemmer/work/compwrap/cc/usr/bin/clang -O2 -W -Wall -Wmissing-prototypes -Wmissing-declarations   -c -o compiler/space.o compiler/space.c

[ryandesign (Ryan Carsten Schmidt)]

Replying to lukaso:

It needs something like:

CFLAGS += -mmacosx-version-min=$MACOSX_DEPLOYMENT_TARGET
LDFLAGS += -Wl,-macosx_version_min,$MACOSX_DEPLOYMENT_TARGET

being added to the GNUMakefile

MacPorts automatically sets the MACOSX_DEPLOYMENT_TARGET environment variable to the correct value during all port phases which is sufficient unless the build system is deliberately overriding that elsewhere.

[jmroot (Joshua Root)]

In 6d75c22ebad1cf495e688fba8cbc4db9266d6286/macports-ports (master):

libstemmer: use the right deployment target, CC, etc

Also install docs and distribute the copyright notices and license text
as required by the BSD license.

Fixes: #67899