py311-gnureadline @8.1.2: build failure

[MaddTheSane (C.W. Betts)]

Another port that seems to be broken for Sonoma, on Apple Silicon

Log will be added.

[MaddTheSane (C.W. Betts)]

Build log

[jmroot (Joshua Root)]

Looks like ​https://github.com/python/cpython/issues/109191, which is unexpected because that implies this is building against libedit headers instead of its own GNU readline headers.

[reneeotten (Renee Otten)]

has duplicate: 68280

[markmentovai (Mark Mentovai)]

Replying to jmroot:

Looks like ​https://github.com/python/cpython/issues/109191, which is unexpected because that implies this is building against libedit headers instead of its own GNU readline headers.

gnureadline’s Modules/3.x/readline.c has this:

#ifdef WITH_EDITLINE
#  include <editline/readline.h>
#else
/* GNU readline definitions */
#  undef HAVE_CONFIG_H /* Else readline/chardefs.h includes strings.h */
#  include <readline/readline.h>
#  include <readline/history.h>
#endif

The problem is that earlier in the same file, there’s

#include "Python.h"

"Python.h" is resolved as ${prefix}/Library/Frameworks/Python.framework/Versions/3.11/include/python3.11/Python.h; it #includes "pyconfig.h" from the same directory, and that file contains:

/* Define to build the readline module against Editline. */
#define WITH_EDITLINE 1

This, of course, refers to Python’s own built-in readline module, and should not be effective during the build of py-gnureadline, which is expecting and has configured itself to use its own embedded copy of GNU readline.

As a fix, I think we can just remove (or replace with #if 0) that WITH_EDITLINE branch.

[markmentovai (Mark Mentovai)]

​https://github.com/macports/macports-ports/pull/20636

[Mark Mentovai <mark@…>]

In c338199ad1fcf0328a7fce5572d856388930aee3/macports-ports (master):

py-gnureadline: Fix build when Python's readline module uses editline

Fixes: #68265

[jmroot (Joshua Root)]

I guess this should be upstreamed as well, though they may want a fix that won't be wiped out when they import the latest readline module code from cpython core.

[markmentovai (Mark Mentovai)]

Yes, I am attempting to upstream it at ​https://github.com/ludwigschwardt/python-gnureadline/pull/64.