Opened 7 months ago
Last modified 7 months ago
#68460 new defect
homepage URLs in portfiles: move extra URLs into long_description or notes
| Reported by: | barracuda156 | Owned by: | |
|---|---|---|---|
| Priority: | Low | Milestone: | |
| Component: | ports | Version: | 2.8.1 |
| Keywords: | Cc: | ||
| Port: | R-S4Vectors, i2pd |
Description
See as an example: https://ports.macports.org/port/R-S4Vectors I.e. while textually they are distinct, website glues them into single, and therefore broken, link.
Change History (11)
comment:1 Changed 7 months ago by jmroot (Joshua Root)
comment:2 Changed 7 months ago by ryandesign (Ryan Carsten Schmidt)
| Component: | website → ports |
|---|---|
| Port: | R-S4Vectors added |
| Summary: | Website parsing bug: If more than one, homepage links are glued together on port pages → R-S4Vectors: Should have only one URL in homepage |
It's true that homepage is intended to have a single URL. See https://guide.macports.org/#reference.keywords.
However we do have other options with a singular name that are intended to take multiple values. The one that springs to mind is license. I would love for that to be renamed to licenses one day to clear up the confusion. See comment:ticket:61237:4 for some more ideas about when a good time to make that switch might be.
If this were a bug of the web page you mentioned, it would not be a "website" bug (which refers to www.macports.org); it would be a "webapp" bug (which refers to ports.macports.org). Webapp bugs are tracked at https://github.com/macports/macports-webapp/issues, not in Trac.
comment:3 follow-up: 4 Changed 7 months ago by barracuda156
Is there any reasoning to require a single website? Also, perhaps, it should not be allowed explicitly, if it does not work.
- S. Opened an issue: https://github.com/macports/macports-webapp/issues/363
comment:4 follow-up: 5 Changed 7 months ago by ryandesign (Ryan Carsten Schmidt)
Replying to barracuda156:
it should not be allowed explicitly, if it does not work.
What do you want MacPorts to do when you provide invalid input?
comment:5 Changed 7 months ago by barracuda156
Replying to ryandesign:
Replying to barracuda156:
it should not be allowed explicitly, if it does not work.
What do you want MacPorts to do when you provide invalid input?
Improve Macports by fixing multiple URL parsing. Or at least being explained why that is undesirable.
Also, if input is invalid, lint should fail, but it does not.
comment:6 Changed 7 months ago by barracuda156
| Summary: | R-S4Vectors: Should have only one URL in homepage → URL in portfiles: either allow parsing more than one, or remove extra ones from portfile which have them (and fix lint behavior) |
|---|
comment:7 Changed 7 months ago by barracuda156
| Port: | i2pd added |
|---|---|
| Summary: | URL in portfiles: either allow parsing more than one, or remove extra ones from portfile which have them (and fix lint behavior) → homepage URLs in portfiles: either allow parsing more than one, or remove extra ones from portfiles which have them (and fix lint behavior) |
comment:8 Changed 7 months ago by barracuda156
Okay, this sounded a convincing reason not to have several URLs in homepage field: https://github.com/macports/macports-webapp/issues/363#issuecomment-1783351867 If anything, a separate field is needed.
comment:9 Changed 7 months ago by barracuda156
| Summary: | homepage URLs in portfiles: either allow parsing more than one, or remove extra ones from portfiles which have them (and fix lint behavior) → homepage URLs in portfiles: should be either strictly one per port, or additional filed is needed for documentation links |
|---|
comment:10 Changed 7 months ago by barracuda156
| Summary: | homepage URLs in portfiles: should be either strictly one per port, or additional filed is needed for documentation links → homepage URLs in portfiles: move extra URLs into long_description or notes |
|---|
comment:11 Changed 7 months ago by barracuda156
| Priority: | Normal → Low |
|---|
The option is homepage singular, not homepages plural.