OpenSMTPD 7.4.0p0 released yet updating not going so smoothly at the moment.

[artkiver (グレェ)]

OpenSMTPD 7.4.0p0 was released on 2023-10-25 which includes some bug fixes (see: ​https://opensmtpd.org/announces/release-7.4.0p0.txt for release notes).

Preliminary attempts to modify the Portfile and install via MacPorts have unfortunately, not gone so smoothly.

So I am opening this Trac issue to document progress, ranging from a diff to modify the Portfile, a main.log output from MacPorts, as well as attempting to build from the source tarball using the README.md instructions.

[artkiver (グレェ)]

diff from the previous Portfile to update to 7.4.0p0

[artkiver (グレェ)]

main.log from failed installation attempt of OpenSMTPD 7.4.0p0 via MacPorts

[artkiver (グレェ)]

error output from attempting to build OpenSMTPD 7.4.0p0 using the method as described in README.md on macOS 14.2

[artkiver (グレェ)]

I've also opened an issue upstream: ​https://github.com/OpenSMTPD/OpenSMTPD/issues/1232

Admittedly, I have only attempted to test locally on one system so far, but that system was able to build 7.3.0p2 OK.

[ryandesign (Ryan Carsten Schmidt)]

Looks like opensmtpd is trying to declare a function strlcpy via its bundled copy of openbsd-compat, despite the fact that macOS already has strlcpy, which the configure script correctly identified.

[artkiver (グレェ)]

OpenSMTPD 7.4.0p1 has been released with fixes from upstream which do seem to build locally.

However, my minor modifications to the Portfile were not yet sufficient to submit a PR.

Attaching some logs, etc. for reference.

[artkiver (グレェ)]

preliminary diff for Portfile for 7.4.0p1

[artkiver (グレェ)]

main.log from failed port -v install for opensmtpd 7.4.0p1

[artkiver (グレェ)]

config.log referenced by failed port -v install for opensmtpd 7.4.0p1

[artkiver (グレェ)]

a functioning diff for OpenSMTPD 7.4.0p1 by removing --with-mantype=doc \

[artkiver (グレェ)]

full Portfile for OpenSMTPD 7.4.0p1 (in case of confusion of diffs)

[artkiver (グレェ)]

It seems as if removing the following line from the Portfile:

--with-mantype=doc \

Is sufficient to get it to configure and build correctly.

port -vst install is also OK after that.

Same for port lint --nitpick.

When running port -test the following output is generated, but IIRC, the previous version in MacPorts also did not finish port test cleanly, nor the version before that.

# port test          
--->  Computing dependencies for opensmtpd
--->  Fetching distfiles for opensmtpd
--->  Verifying checksums for opensmtpd
--->  Extracting opensmtpd
--->  Configuring opensmtpd
Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled:
  strchr: found in opensmtpd-7.4.0p1/config.log
--->  Building opensmtpd
--->  Staging opensmtpd into destroot                    
--->  Creating launchd control script 'opensmtpd'
--->  Testing opensmtpd                                  
Error: Failed to test opensmtpd: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_mail_opensmtpd/opensmtpd/work/destroot/opt/local/var/spool/smtpd: permission denied
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_mail_opensmtpd/opensmtpd/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port opensmtpd failed

Anyway, I can submit a PR as is, but thought I would at least document things here and see if there might be another suggestion regarding the change to the configure.args for

--with-mantype=doc \

before proceeding further.

Thanks!

[artkiver (グレェ)]

Omar Polo noticed the mantype thing was a typo and fixed upstream here: ​https://github.com/OpenSMTPD/OpenSMTPD/issues/1232#issuecomment-1815209272

I submitted a PR with some local patches to 7.4.0p1 reflecting that upstream change not yet tagged in a release so that omitting the --with-mantype=doc \ from the Portfile is no longer necessary here:

​https://github.com/macports/macports-ports/pull/21431

[artkiver (グレェ)]

In 12a052535c23600d4829bec9fe3b80859812bef7/macports-ports (master):

opensmtpd: update to 7.5.0p0

Closes: #68573
Closes: #69456