MenuMeters @1.1.6.1: error: a function declaration without a prototype is deprecated in all versions of C

[pipp8 (Pippo Cattaneo)]

After upgrading Mac Port menumeters disappered from the menu bar and the new installation fails with the following message (no detail in the log file):

bash-3.2# port install MenuMeters
--->  Fetching archive for MenuMeters
--->  Attempting to fetch MenuMeters-2.1.6.1_0.darwin_23.x86_64.tbz2 from https://packages.macports.org/MenuMeters
--->  Attempting to fetch MenuMeters-2.1.6.1_0.darwin_23.x86_64.tbz2 from http://fco.it.packages.macports.org/MenuMeters
--->  Attempting to fetch MenuMeters-2.1.6.1_0.darwin_23.x86_64.tbz2 from https://fra.de.packages.macports.org/MenuMeters
--->  Staging MenuMeters into destroot
Error: Failed to destroot MenuMeters: command execution failed

Log file has a huge list of command but no error.

Did you plan a port to sonoma in next releases ?

thank you

[ryandesign (Ryan Carsten Schmidt)]

Please attach the main.log file. If it is large, compress it first.

[pipp8 (Pippo Cattaneo)]

Installation main.log file

[ryandesign (Ryan Carsten Schmidt)]

Ok, your log matches what we see on our Sonoma buildbot worker:

:info:destroot /opt/local/var/macports/build/_opt_local_var_macports_sources_distfiles.macports.org_ports_aqua_MenuMeters/MenuMeters/work/MenuMeters-2.1.6.1/hardware_reader/smc_reader.m:6:22: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
:info:destroot kern_return_t SMCOpen()
:info:destroot                      ^
:info:destroot                       void
:info:destroot /opt/local/var/macports/build/_opt_local_var_macports_sources_distfiles.macports.org_ports_aqua_MenuMeters/MenuMeters/work/MenuMeters-2.1.6.1/hardware_reader/smc_reader.m:38:23: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
:info:destroot kern_return_t SMCClose()
:info:destroot                       ^
:info:destroot                        void

:info:destroot /opt/local/var/macports/build/_opt_local_var_macports_sources_distfiles.macports.org_ports_aqua_MenuMeters/MenuMeters/work/MenuMeters-2.1.6.1/hardware_reader/applesilicon_hardware_reader.m:57:28: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
:info:destroot static void initEventSystem(){
:info:destroot                            ^
:info:destroot                             void

The fix for this issue was submitted to the developers of MenuMeters here but has not yet been accepted:

​https://github.com/yujitach/MenuMeters/pull/305/commits/5c44f1f9bf97d01a75a73d7aaddea049564ad68c

We could apply that patch to MacPorts.

[Tatsh (Andrew Udvare)]

I am wondering why the developer wants to use -Werror in a release build. Could turn that off to avoid further issues caused by -Werror in the future.

[ryandesign (Ryan Carsten Schmidt)]

Yes that would be a good idea too.

[llucps]

Just a quick update and menumeters compiles and works fine under Sonoma.

[ryandesign (Ryan Carsten Schmidt)]

Landon fixed it in [652acb048c7600087fe177948beb1f142da4c9ad/macports-ports]. Thanks, Landon!