lfortran @0.29.0 Fails to link on 10.9 due to missing -lMacportsLegacySupport and our libc++.dylib

[badger200]

Lfortran .>0.21 have been broken this way. The fix is easy. CMake settings for EXE LINK should simply add -lMacportsLegacySupport and /opt/local/lib/libcxx/libc++.dylib. Now lfortran and associated binaries successfully link and the port completes its build.

[barracuda156]

Replying to badger200:

Lfortran .>0.21 have been broken this way. The fix is easy. CMake settings for EXE LINK should simply add -lMacportsLegacySupport and /opt/local/lib/libcxx/libc++.dylib. Now lfortran and associated binaries successfully link and the port completes its build.

Could you please submit PR with a fix? (I do not have commit access to fix anything directly.)

16. S. If you do, please make adding flags conditional: PowerPC builds (and provisionally Intel with libstdc++) are fine and should not be linked to libc++.

[badger200]

@barracuda156 I’m afraid I don’t have the means to submit a PR.

[barracuda156]

Replying to badger200:

@barracuda156 I’m afraid I don’t have the means to submit a PR.

I think anyone can do it (merging gonna require an approval, but submitting is open to everyone), but if you share a suggested fix here, I can open a PR from my end. (I cannot test on 10.9 though, and cannot test on any Intel at the moment.)

[badger200]

Replying to barracuda156:

Replying to badger200:

@barracuda156 I’m afraid I don’t have the means to submit a PR.

I think anyone can do it (merging gonna require an approval, but submitting is open to everyone), but if you share a suggested fix here, I can open a PR from my end. (I cannot test on 10.9 though, and cannot test on any Intel at the moment.)

No I was trying to politely explain I literally don’t know how to submit a PR or how to implement this fix properly. I just personally used ccmake to add those arguments to the EXE LINK section and was able to complete the build. If there is a guide somewhere that would aid me, let me know. I know MacPorts has its own system of doing things but I don’t really know how it works internally. I also don’t even have the repo.