pgpointcloud: depends on port:icu

[barracuda156]

svacchanda@Sergeys-MacBook-Air ~ % sudo port -v install pdal
--->  Computing dependencies for pdal.....
Error: Can't install icu because conflicting ports are active: icu-devel
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port pdal failed

16. S. I thought it was fixed repo-wide already. Apparently not.

[catap (Kirill A. Korinsky)]

Sergey, the issue came from port pgpointcloud

[nilason (Nicklas Larsson)]

While pgpointcloud does indeed links to icu, it does so via xml2-config (of port libxml2). icu is not a direct dependency to pgpointcloud.

I'm not sure what would be the best solution to this: remove icu dependency all together; replace it with with path-based dependency; or something completely different...

[ryandesign (Ryan Carsten Schmidt)]

If pgpointcloud links with an icu library, it should declare a dependency on it. And it should do so with a path:-based dependency so that icu-devel could satisfy it.

Even better: use xml2-config --libs --dynamic instead of xml2-config --libs so that you don't pull in icu and other transitive dependencies and then remove those dependencies.

Even better: use pkg-config libxml-2.0 --libs and then remove those dependencies.

[nilason (Nicklas Larsson)]

Thanks Ryan! This is now addressed with ​https://github.com/macports/macports-ports/pull/21415.

[nilason (Nicklas Larsson)]

In a0ba2fb1b535fb013a117ea6960d241634115827/macports-ports (master):

pgpointcloud: remove icu, lzma, libiconv dependencies; fix '--without-cunit' flag

Remove dependencies unnecessary linked to as a result of xml2-config --libs.

Closes #68704

Fix for honoring --without-cunit flag is addressed upstreams:
​https://github.com/pgpointcloud/pointcloud/pull/349