llvm-14: debug variant is not CMAKE_BUILD_TYPE=Debug

[infinitesteps (infinitesteps)]

When I installed the +debug port variant I expected that the build type would be:

CMAKE_BUILD_TYPE=Debug

It would be helpful if it was. But it is not:

❯ /opt/local/bin/opt-mp-14 --version 
LLVM (http://llvm.org/):
  LLVM version 14.0.6
  Optimized build.
  Default target: x86_64-apple-darwin21.6.0
  Host CPU: skylake

If it was the debug build it would report as follows:

❯ bin/opt --version
LLVM (http://llvm.org/):
  LLVM version 14.0.6
  DEBUG build with assertions.
  Default target: x86_64-apple-darwin21.6.0
  Host CPU: skylake

[jmroot (Joshua Root)]

This variant is implemented in the cmake portgroup: ​https://github.com/macports/macports-ports/blob/55bc075f7e5ef04ff3a822ed725880c3858d93a6/_resources/port1.0/group/cmake-1.1.tcl#L486

[ryandesign (Ryan Carsten Schmidt)]

Right, because of "reasons" the cmake-1.1 portgroup sets the build type to "MacPorts", which causes problems for a variety of build systems that weren't expecting that, I guess including LLVM's. The cmake-1.0 portgroup didn't do this, instead using the standard "Release" and "Debug" build types. At some point the cmake-1.1 portgroup may need to be abandoned as a failed experiment and a new version based on the cmake-1.0 portgroup might need to be used instead.