vigra @1.11.1 broken with the new hdf5: hdf5impex.cxx: error: too few arguments to function 'herr_t H5Oget_info_by_name3(hid_t, const char*, H5O_info2_t*, unsigned int, hid_t)'

[barracuda156]

:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/include/vigra/stdconvolution.hxx:43,
:info:build                  from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/include/vigra/convolution.hxx:41,
:info:build                  from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/vigranumpy/src/core/convolution.cxx:45:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/include/vigra/separableconvolution.hxx: At global scope:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/include/vigra/separableconvolution.hxx:1413:13: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
:info:build  1413 |             throw(PreconditionViolation)
:info:build       |             ^~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/include/vigra/stdconvolution.hxx:796:13: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
:info:build   796 |             throw(PreconditionViolation)
:info:build       |             ^~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/src/impex/hdf5impex.cxx: In function 'H5O_type_t vigra::HDF5_get_type(hid_t, const char*)':
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/src/impex/hdf5impex.cxx:193:24: error: too few arguments to function 'herr_t H5Oget_info_by_name3(hid_t, const char*, H5O_info2_t*, unsigned int, hid_t)'
:info:build   193 |     H5Oget_info_by_name(loc_id, name, &infobuf, H5P_DEFAULT);
:info:build       |                        ^
:info:build In file included from /opt/local/include/H5Apublic.h:21,
:info:build                  from /opt/local/include/hdf5.h:22,
:info:build                  from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_vigra/vigra/work/vigra-1-11-1/include/vigra/hdf5impex.hxx:51:
:info:build /opt/local/include/H5Opublic.h:540:15: note: declared here
:info:build   540 | H5_DLL herr_t H5Oget_info_by_name3(hid_t loc_id, const char *name, H5O_info2_t *oinfo, unsigned fields,
:info:build       |               ^~~~~~~~~~~~~~~~~~~~
:info:build make[2]: *** [src/impex/CMakeFiles/vigraimpex.dir/hdf5impex.cxx.o] Error 1

​https://github.com/ukoethe/vigra/issues/556

[Dave-Allured (Dave Allured)]

There is a new release, ​vigra 1.11.2, several years more recent than 1.11.1. I see that an HDF5 interface update is included. This might fix the above problem with H5Oget_info_by_name.

I started to update the portfile. After fixing several things, I ran short on time, and also I ran into stuff that I do not know how to fix. Please visit my draft PR at ​https://github.com/Dave-Allured/macports-ports/pull/4. Any advice or suggestions would be appreciated. If anyone would like to run their own update, please feel free to copy my draft portfile.

[Christopher Nielsen <mascguy@…>]

In 9d2ccd38b73305f824df2f8f699a0a0b5af88afc/macports-ports (master):

vigra: add patch for hdf5 compat; fix livecheck

Fixes: #69007

[mascguy (Christopher Nielsen)]

On a related note: For HDF5, Vigra requires two other lib deps: zlib and szip. And while the port currently pulls in the former, the latter is missing.

As a result, when installed via trace mode, HDF5 support is disabled. Ditto for systems without szip installed/active, like our buildbots. (Which explains why we haven't seen similar failures on our builders.)

Will check in a fix momentarily.

[Christopher Nielsen <mascguy@…>]

In 9f38a8bb7c1cc0fec97f702d812a23d0050c13c0/macports-ports (master):

vigra: add lib dep szip, required for hdf5 support

See: #69007

[barracuda156]

Replying to Christopher Nielsen <mascguy@…>:

In 9f38a8bb7c1cc0fec97f702d812a23d0050c13c0/macports-ports (master):

vigra: add lib dep szip, required for hdf5 support

See: #69007

Thank you, Christopher!

[eborisch (Eric A. Borisch)]

Replying to mascguy:

On a related note: For HDF5, Vigra requires two other lib deps: zlib and szip. And while the port currently pulls in the former, the latter is missing.

As a result, when installed via trace mode, HDF5 support is disabled. Ditto for systems without szip installed/active, like our buildbots. (Which explains why we haven't seen similar failures on our builders.)

Will check in a fix momentarily.

Note that HDF5 uses libaec (replacement lib with BSD license) rather than szip anymore.

[mascguy (Christopher Nielsen)]

Replying to eborisch:

Note that HDF5 uses libaec (replacement lib with BSD license) rather than szip anymore.

Thanks for the heads-up, will fix over the coming days.

In the interim, will szip cause any issues, apart from preventing distribution of binaries for vigra?

[Dave-Allured (Dave Allured)]

In the interim, will szip cause any issues, apart from preventing distribution of binaries for vigra?

There should be no such issues. Vigra was developed on szip, not libaec.