Opened 5 months ago
Closed 5 months ago
#69027 closed defect (fixed)
ddptools should set supported_archs
| Reported by: | barracuda156 | Owned by: | breun (Nils Breunese) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.8.1 |
| Keywords: | Cc: | ||
| Port: | ddptools |
Description
Binaries from 2018 perhaps do not support aarch64 either, and I am sure they cannot possibly have all 5 archs.
Change History (7)
comment:1 Changed 5 months ago by jmroot (Joshua Root)
comment:2 Changed 5 months ago by jmroot (Joshua Root)
| Summary: | ddptools is not Darwin any → ddptools should set supported_archs |
|---|
comment:3 Changed 5 months ago by breun (Nils Breunese)
The ddptools binaries are indeed x86_64, but they also work on arm64 via Rosetta 2. Should supported_archs be set to just x86_64 or to x86_64 arm64 in this case?
comment:4 Changed 5 months ago by breun (Nils Breunese)
It looks like just supported_archs x86_64 works fine on my arm64 device.
comment:5 Changed 5 months ago by breun (Nils Breunese)
Pull request: https://github.com/macports/macports-ports/pull/22033
comment:6 Changed 5 months ago by breun (Nils Breunese)
Pull request was merged, but I guess I forgot to add the incantation that closes this ticket in the commit message, and I can't close it myself. Can one of you close this Trac ticket?
comment:7 Changed 5 months ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
It installs the same files regardless of OS version, so yes, it is darwin any. But if it only provides an x86_64 binary it should set supported_archs accordingly. If there's a minimum OS version it works on, it can set something like
platforms {darwin any >= n}.