c4core is broken on Mojave and below when built with Clang

[barracuda156]

The port fails to build on < 10.15 with multiple errors. See: ​https://github.com/biojppm/c4core/issues/130

In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/error.cpp:1:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/error.hpp:8:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/config.hpp:37:
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/types.hpp:150:12: error: unknown type name 'T'
    Padded(T const& val) : T(val) {}
           ^
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/types.hpp:150:14: error: expected ')'
    Padded(T const& val) : T(val) {}
             ^
. . .
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/format.cpp:1:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/format.hpp:7:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/charconv.hpp:50:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/std/std_fwd.hpp:6:
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_c4core/c4core/work/c4core-0.1.11-src/src/c4/std/vector_fwd.hpp:29:2: error: "unknown standard library"
#error "unknown standard library"
 ^
. . .

​https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/180210/steps/install-port/logs/stdio

On < 10.7 it does not find git during configure:

CMake Error at cmake/c4Project.cmake:1042 (find_program):
  Could not find GIT using the following names: git
Call Stack (most recent call first):
  cmake/c4Project.cmake:884 (c4_proj_get_version)
  cmake/c4Project.cmake:825 (c4_set_default_pack_properties)
  CMakeLists.txt:110 (c4_pack_project)


-- Configuring incomplete, errors occurred!

​https://build.macports.org/builders/ports-10.6_x86_64-builder/builds/191688/steps/install-port/logs/stdio

[barracuda156]

But only with Clang; with GCC it builds just fine.

[ryandesign (Ryan Carsten Schmidt)]

Replying to barracuda156:

​https://github.com/biojppm/c4core/issues/130

error: "unknown standard library"

Per my remarks in that issue, I believe blacklisting Apple clang < 1100 would be a workaround for this. I don't know if that will resolve the other errors.

On < 10.7 it does not find git during configure:

It would be helpful to limit each ticket to a single issue. Somebody who has time and knowledge to solve one issue may not have time and knowledge to solve another issue so it is helpful for each problem to be in its own ticket so that each can be closed or left open as needed.

[ryandesign (Ryan Carsten Schmidt)]

In 13e22051a97f5c566b394f5b8ec9aa50b89fb740/macports-ports (master):

c4core: Blacklist clang < 1100

See: #69435

[ryandesign (Ryan Carsten Schmidt)]

Replying to barracuda156:

On < 10.7 it does not find git during configure:

CMake Error at cmake/c4Project.cmake:1042 (find_program):
  Could not find GIT using the following names: git
Call Stack (most recent call first):
  cmake/c4Project.cmake:884 (c4_proj_get_version)
  cmake/c4Project.cmake:825 (c4_set_default_pack_properties)
  CMakeLists.txt:110 (c4_pack_project)


-- Configuring incomplete, errors occurred!

I filed ​https://github.com/biojppm/c4core/issues/131 about this.

[ryandesign (Ryan Carsten Schmidt)]

In 6bee2aa73134208da12426aacead6763d6e62fdb/macports-ports (master):

c4core: Add git dependency

Closes: #69435