kicad @7.0.10_1: fails to configure with opencascade 7.8.0

[randymortensen (Randy Mortensen)]

During a regular port upgrade outdated, rebuilding kicad was attempted but failed to configure.

Seems that cmake is complaining about missing opencascade during configure.

Log file is attached.

MacBook Pro with M1 Pro, Sonoma 14.4, Xcode 15.3

[ryandesign (Ryan Carsten Schmidt)]

:info:configure -- Found OCC: /opt/local/libexec/opencascade/include/opencascade (found version "7.8.0") 
:info:configure *** OpenCascade library missing ***
:info:configure Could not find a library for TKIGES at /opt/local/libexec/opencascade/lib

Did something change about opencascade when it was updated to 7.8.0 yesterday?

[barracuda156]

Replying to ryandesign:

:info:configure -- Found OCC: /opt/local/libexec/opencascade/include/opencascade (found version "7.8.0") 
:info:configure *** OpenCascade library missing ***
:info:configure Could not find a library for TKIGES at /opt/local/libexec/opencascade/lib

Did something change about opencascade when it was updated to 7.8.0 yesterday?

Not anything to that effect from our side, I think: [de48eabbf78f17a13f9c816b4b294a02732603f3/macports-ports]

[gergomez]

Probably this ​https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277311

[ra1nb0w]

@randymortensen do you know how to try the patch posted by gergomez? thanks

[randymortensen (Randy Mortensen)]

Unfortunately no, I don't know how to work with that patch.

[barracuda156]

Replying to randymortensen:

Unfortunately no, I don't know how to work with that patch.

What is the difficulty though? Just add it to patchfiles-append :)

​https://bz-attachments.freebsd.org/attachment.cgi?id=248764

[randymortensen (Randy Mortensen)]

Hmm, I just attempted that without success. Downloaded that link, changed /opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/science/kicad/Portfile and added the .diff file to "files" subdirectory.

     patchfiles-append \
        macports_prefix.patch \
        0001-cmake-adding-KICAD_MACOSX_APP_BUNDLE-option.patch \
        0002-disable-codesigning.patch \
        patch-kicad+OCCT-7.8.diff

Rebuilding kicad now just hangs at "Applying patches to kicad"

The following ports will be rebuilt: kicad @7.0.10
Continue? [Y/n]: 
--->  Computing dependencies for kicad
--->  Cleaning kicad
--->  Scanning binaries for linking errors
--->  Found 90 broken files, matching files to ports
--->  Found 1 broken port, determining rebuild order
--->  Rebuilding in order
     kicad @7.0.10_1
--->  Computing dependencies for kicad
--->  Fetching distfiles for kicad
--->  Verifying checksums for kicad
--->  Extracting kicad
--->  Applying patches to kicad
^CError: rev-upgrade aborted: SIGINT received.

[ryandesign (Ryan Carsten Schmidt)]

That is a new behavior of the macOS 14 version of the patch command, which has a different provenance than the patch command that Apple shipped in macOS 13 and earlier. The old patch command would give an error message when something failed. The new patch command waits for user input, even when it is not attached to an interactive shell, so it appears as a hang. It probably means the patch did not apply correctly in that form.

[ryandesign (Ryan Carsten Schmidt)]

Replying to barracuda156:

What is the difficulty though? Just add it to patchfiles-append :)

​https://bz-attachments.freebsd.org/attachment.cgi?id=248764

That patch, as it is written, patches the FreeBSD build system for this port. That's not going to work in the slightest for MacPorts. It needs to be converted to the MacPorts way that that would be handled.

[ryandesign (Ryan Carsten Schmidt)]

The failure of the macOS 14 patch command here could even relate to the port's existing patches, since they have not been refreshed to apply cleanly. The macOS 14 version of the patch command is more sensitive to that.

I'm working on fixing this now.

[ryandesign (Ryan Carsten Schmidt)]

In 6018a769e6a000d9ceb56fea57f79bbb349ff55b/macports-ports (master):

kicad: Fix build with opencascade 7.8.x

And use path:-based dependencies and refresh patches.

Closes: #69584

[randymortensen (Randy Mortensen)]

Thanks for this and the update to 7.0.11